Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Into<PathBuf> to improve Linter usability #77

Merged
merged 1 commit into from Jan 12, 2020

Conversation

ebroto
Copy link
Contributor

@ebroto ebroto commented Jan 12, 2020

It seems that we don't need to work with associated types in this case. I guess it's because the type parameter is on the method and not on the trait itself?

Closes #75

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.3%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   92.54%   92.24%   -0.31%     
==========================================
  Files           7        7              
  Lines         604      606       +2     
==========================================
  Hits          559      559              
- Misses         45       47       +2
Impacted Files Coverage Δ
cargo-scout-lib/src/linter/clippy.rs 84.29% <0%> (-0.71%) ⬇️
cargo-scout-lib/src/linter/rustfmt.rs 88.23% <0%> (-1.32%) ⬇️
cargo-scout-lib/src/scout/mod.rs 97.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6737bb1...196eb11. Read the comment docs.

Copy link
Owner

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that's really cool! Thanks for doing it 🎉

@o0Ignition0o o0Ignition0o merged commit 7a80947 into o0Ignition0o:master Jan 12, 2020
@ebroto ebroto deleted the impl-into-pathbuf branch January 12, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter: Use Into<PathBuf> instead of Pathbuf ?
2 participants