From 84ed97a0fab3e4fa32f77b97cbc0f057c55d314a Mon Sep 17 00:00:00 2001 From: Bruno Deferrari Date: Thu, 9 May 2024 19:51:20 -0300 Subject: [PATCH] tweak: Rename `zero` methods to `empty` which better describes what they do --- core/src/block/genesis.rs | 2 +- mina-p2p-messages/src/v2/manual.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/block/genesis.rs b/core/src/block/genesis.rs index 152782a3fc..889da6217d 100644 --- a/core/src/block/genesis.rs +++ b/core/src/block/genesis.rs @@ -100,7 +100,7 @@ fn blockchain_state( let stmt_registers = v2::MinaStateBlockchainStateValueStableV2LedgerProofStatementSource { first_pass_ledger: genesis_ledger_hash.clone(), second_pass_ledger: genesis_ledger_hash.clone(), - pending_coinbase_stack: v2::MinaBasePendingCoinbaseStackVersionedStableV1::zero(), + pending_coinbase_stack: v2::MinaBasePendingCoinbaseStackVersionedStableV1::empty(), local_state: empty_local_state, }; let empty_fee_excess = v2::TokenFeeExcess { diff --git a/mina-p2p-messages/src/v2/manual.rs b/mina-p2p-messages/src/v2/manual.rs index d07414b074..f8843ec121 100644 --- a/mina-p2p-messages/src/v2/manual.rs +++ b/mina-p2p-messages/src/v2/manual.rs @@ -256,7 +256,7 @@ impl EpochSeed { } impl CoinbaseStackData { - pub fn zero() -> Self { + pub fn empty() -> Self { // In OCaml: https://github.com/MinaProtocol/mina/blob/68b49fdaafabed0f2cd400c4c69f91e81db681e7/src/lib/mina_base/pending_coinbase.ml#L186 // let empty = Random_oracle.salt "CoinbaseStack" |> Random_oracle.digest let empty = super::hash_noinputs("CoinbaseStack"); @@ -320,9 +320,9 @@ impl super::MinaBasePendingCoinbaseUpdateStableV1 { } impl super::MinaBasePendingCoinbaseStackVersionedStableV1 { - pub fn zero() -> Self { + pub fn empty() -> Self { Self { - data: CoinbaseStackData::zero(), + data: CoinbaseStackData::empty(), state: super::MinaBasePendingCoinbaseStateStackStableV1 { init: CoinbaseStackHash::zero(), curr: CoinbaseStackHash::zero(),