Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup bindings for hex serialization #37

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jun 7, 2023

This PR updates the bindings for the latest changes to the proof-systems repo.

This

  • uses the hex option for generating the poseidon test vectors
  • updates the poseidon test to work correctly with hex strings as input and output
    • previously input was base-10, but output was hex!
  • updates the serde rules to use is_human_readable: false, so that we don't generate hex strings for field elements across the FFI boundary

Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the serialization changes look good, but CI now fails in caml_pasta_fp_proof_of_rust:
https://github.com/o1-labs/snarkyjs/actions/runs/5203561513/jobs/9386575314

nit: you don't auto-format the code with prettier, maybe we should add a quick command to do so. but not important

Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snarkyjs CI should work before landing this

@mitschabaude mitschabaude merged commit ef552a3 into develop Jun 8, 2023
@mitschabaude mitschabaude deleted the feature/fixup-proof-system-serialization branch June 8, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants