Merge pull request #919 from o1-labs/fix/graphql-errors-check

Add better error checking for fetched GraphQL requests
o1-labs · May 23, 2023 · f2257f6 · f2257f6
2 parents 1207ded + 58a4fc4
commit f2257f6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 ### Fixed
 
 - Fix running SnarkyJS in Node.js on Windows https://github.com/o1-labs/snarkyjs-bindings/pull/19 (@wizicer)[https://github.com/wizicer]
+- Fix error reporting from GraphQL requests https://github.com/o1-labs/snarkyjs/pull/919
 
 ## [0.10.1](https://github.com/o1-labs/snarkyjs/compare/bcc666f2...a632313a)
 

diff --git a/src/lib/fetch.ts b/src/lib/fetch.ts
@@ -1086,7 +1086,17 @@ async function checkResponseStatus(
         undefined,
         {
           statusCode: response.status,
-          statusText: jsonResponse.errors,
+          statusText: jsonResponse.errors
+            .map((error: any) => error.message)
+            .join('\n'),
+        } as FetchError,
+      ];
+    } else if (jsonResponse.data === undefined) {
+      return [
+        undefined,
+        {
+          statusCode: response.status,
+          statusText: `GraphQL response data is undefined`,
         } as FetchError,
       ];
     }