Commits on Sep 18, 2013
  1. mac80211: make CONFIG_MAC80211_MESH=y default

    Signed-off-by: Thomas Pedersen <>
    twpedersen committed with jasonabele Jan 8, 2013
Commits on Sep 14, 2013
  1. Linux 3.11.1

    gregkh committed Sep 14, 2013
  2. mwifiex: do not create AP and P2P interfaces upon driver loading

    commit 1211c96 upstream.
    Bug 60747 - 1286:2044 [Microsoft Surface Pro]
        Marvell 88W8797 wifi show 3 interface under network
    This issue was also reported previously by OLPC and some folks from
    the community.
    There are 3 network interfaces with different types being created
    when mwifiex driver is loaded:
    1. mlan0 (infra. STA)
    2. uap0 (AP)
    3. p2p0 (P2P_CLIENT)
    The Network Manager attempts to use all 3 interfaces above without
    filtering the managed interface type. As the result, 3 identical
    interfaces are displayed under network manager. If user happens to
    click on an entry under which its interface is uap0 or p2p0, the
    association will fail.
    Work around it by removing the creation of AP and P2P interfaces
    at driver loading time. These interfaces can be added with 'iw' or
    other applications manually when they are needed.
    Signed-off-by: Bing Zhao <>
    Signed-off-by: Avinash Patil <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Greg Kroah-Hartman <>
    bingz committed with gregkh Aug 19, 2013
  3. drivers/rtc/rtc-max77686.c: Fix wrong register

    commit 1748cbf upstream.
    Fix a read of the wrong register when checking whether the RTC timer has
    reached the alarm time.
    Signed-off-by: Sangjung Woo <>
    Signed-off-by: Myugnjoo Ham <>
    Reviewed-by: Jonghwa Lee <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
    Signed-off-by: Jonghwan Choi <>
    Signed-off-by: Greg Kroah-Hartman <>
    again4you committed with gregkh Sep 11, 2013
  4. crypto: xor - Check for osxsave as well as avx in crypto/xor

    commit edb6f29 upstream.
    This affects xen pv guests with sufficiently old versions of xen and
    sufficiently new hardware.  On such a system, a guest with a btrfs
    root won't even boot.
    Signed-off-by: John Haxby <>
    Signed-off-by: Herbert Xu <>
    Reported-by: Michael Marineau <>
    Signed-off-by: Greg Kroah-Hartman <>
    John Haxby committed with gregkh Aug 14, 2013
  5. imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id

    commit ea8d158 upstream.
    When building imx_v6_v7_defconfig with imx-drm drivers selected as modules, we
    get the following build error:
    ERROR: "imx_drm_encoder_get_mux_id" [drivers/staging/imx-drm/imx-ldb.ko] undefined!
    Export the required function to avoid this problem.
    Signed-off-by: Fabio Estevam <>
    Acked-by: Sascha Hauer <>
    Acked-by: Philipp Zabel <>
    Cc: Guenter Roeck <>
    Signed-off-by: Greg Kroah-Hartman <>
    Fabio Estevam committed with gregkh Jun 28, 2013
  6. ASoC: fsl: Fix module build

    commit 3f1a91a upstream.
    Building imx_v6_v7_defconfig with all audio drivers as modules results in
    the folowing build error:
    ERROR: "imx_pcm_fiq_init" [sound/soc/fsl/snd-soc-imx-ssi.ko] undefined!
    ERROR: "imx_pcm_dma_init" [sound/soc/fsl/snd-soc-imx-ssi.ko] undefined!
    ERROR: "imx_pcm_fiq_exit" [sound/soc/fsl/snd-soc-imx-ssi.ko] undefined!
    ERROR: "imx_pcm_dma_exit" [sound/soc/fsl/snd-soc-imx-ssi.ko] undefined!
    ERROR: "imx_pcm_dma_init" [sound/soc/fsl/snd-soc-fsl-ssi.ko] undefined!
    ERROR: "imx_pcm_dma_exit" [sound/soc/fsl/snd-soc-fsl-ssi.ko] undefined!
    Fix this by allowing SND_SOC_IMX_PCM_FIQ and SND_SOC_IMX_PCM_DMA to be also
    built as modules and by using 'IS_ENABLED' to cover the module case.
    Reported-by: Guennadi Liakhovetski <>
    Signed-off-by: Fabio Estevam <>
    Acked-by: Shawn Guo <>
    Signed-off-by: Mark Brown <>
    [Guenter Roeck: back-ported to 3.11]
    Signed-off-by: Guenter Roeck <>
    Signed-off-by: Greg Kroah-Hartman <>
    Fabio Estevam committed with gregkh Jul 29, 2013
  7. drivers/misc/hpilo: Correct panic when an AUX iLO is detected

    commit eefbc59 upstream.
     Using an uninitialized variable 'devnum' after 'goto out;' was causing
     panic.  Just go ahead and return, we need to ignore AUX iLO devs.
     Oops: 0002 [#1] SMP
     RIP  [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
    Signed-off-by: Mark Rusk <>
    Signed-off-by: Greg Kroah-Hartman <>
    marker55 committed with gregkh Aug 14, 2013
  8. ACPI / EC: Add ASUSTEK L4R to quirk list in order to validate ECDT

    commit 524f42f upstream.
    The ECDT of ASUSTEK L4R doesn't provide correct command and data
    I/O ports.  The DSDT provides the correct information instead.
    For this reason, add this machine to quirk list for ECDT validation
    and use the EC information from the DSDT.
    [rjw: Changelog]
    Reported-and-tested-by: Daniele Esposti <>
    Signed-off-by: Lan Tianyu <>
    Signed-off-by: Rafael J. Wysocki <>
    Signed-off-by: Greg Kroah-Hartman <>
    Lan Tianyu committed with gregkh Aug 26, 2013
  9. Drivers: hv: vmbus: Fix a bug in the handling of channel offers

    commit 42dceeb upstream.
    The channel state should be correctly set before registering the device. In the current
    code the driver probe would fail for channels that have been rescinded and subsequently
    re-offered. Fix the bug.
    Signed-off-by: K. Y. Srinivasan <>
    Signed-off-by: Greg Kroah-Hartman <>
    kattisrinivasan committed with gregkh Aug 26, 2013
  10. hwmon: (k10temp) Add support for Fam16h (Kabini)

    commit 30b146d upstream.
    The temperature reporting interface stays the same, so we just
    add the PCI-ID to the list.
    Verified on AMD Olive Hill.
    Signed-off-by: Wei Hu <>
    Acked-by: Clemens Ladisch <>
    Signed-off-by: Guenter Roeck <>
    Signed-off-by: Greg Kroah-Hartman <>
    Wei Hu committed with gregkh Aug 23, 2013
  11. usb: acm gadget: Null termintate strings table

    commit d257221 upstream.
    The gadget strings table should be null terminated.
    usb_gadget_get_string() loops through the table
    expecting a null at the end of the list.
    Signed-off-by: Graham Williams <>
    Signed-off-by: Greg Kroah-Hartman <>
    Graham Williams committed with gregkh Aug 28, 2013
  12. mei: me: fix hardware reset flow

    commit ff96066 upstream.
    Both H_IS and H_IE needs to be set to receive H_RDY
    1. Assert H_IS to clear the interrupts during hw reset
    and use mei_me_reg_write instead of mei_hcsr_set as the later
    strips down the H_IS
    2. fix interrupt disablement embarrassing typo
      hcsr |= ~H_IE -> hcsr &= ~H_IE;
    this will remove the unwanted interrupt on power down
    3. remove useless debug print outs
    Signed-off-by: Tomas Winkler <>
    Cc: Shuah Khan <>
    Cc: Konstantin Khlebnikov <>
    Signed-off-by: Greg Kroah-Hartman <>
    tomasbw committed with gregkh Jul 30, 2013
  13. target: Fix se_cmd->state_list leak regression during WRITE failure

    commit c130480 upstream.
    This patch addresses a v3.11 specific regression where se_cmd->state_list
    was being leaked during a fabric WRITE failure, when the fabric releases
    an associated se_cmd descriptor before I/O submission occurs, and normal
    fast path callbacks have a chance to call target_remove_from_state_list().
    It was manifesting with Poison overwritten messages with iscsi-target
    once an ImmediateData payload CRC32C failure occured.
    This bug was originally introduced during v3.11-rc1 with the following
    commit 0b66818
    Author: Nicholas Bellinger <>
    Date:   Thu Jun 6 01:36:41 2013 -0700
        target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd
    Signed-off-by: Nicholas Bellinger <>
    Signed-off-by: Greg Kroah-Hartman <>
    nablio3000 committed with gregkh Aug 31, 2013
  14. iscsi-target: Fix potential NULL pointer in solicited NOPOUT reject

    commit 28aaa95 upstream.
    This patch addresses a potential NULL pointer dereference regression in
    iscsit_setup_nop_out() code, specifically for two cases when a solicited
    NOPOUT triggers a ISCSI_REASON_PROTOCOL_ERROR reject to be generated.
    This is because iscsi_cmd is expected to be NULL for solicited NOPOUT
    case before iscsit_process_nop_out() locates the descriptor via TTT
    using iscsit_find_cmd_from_ttt().
    This regression was originally introduced in:
    commit ba15991
    Author: Nicholas Bellinger <>
    Date:   Wed Jul 3 03:48:24 2013 -0700
        iscsi-target: Fix iscsit_add_reject* usage for iser
    Signed-off-by: Nicholas Bellinger <>
    Signed-off-by: Greg Kroah-Hartman <>
    nablio3000 committed with gregkh Aug 24, 2013
  15. iscsi-target: Fix iscsit_transport reference leak during NP thread reset

    commit c9a03c1 upstream.
    This patch fixes a bug in __iscsi_target_login_thread() where an explicit
    network portal thread reset ends up leaking the iscsit_transport module
    reference, along with the associated iscsi_conn allocation.
    This manifests itself with iser-target where a NP reset causes the extra
    iscsit_transport reference to be taken in iscsit_conn_set_transport()
    during the reset, which prevents the ib_isert module from being unloaded
    after the NP thread shutdown has finished.
    Signed-off-by: Nicholas Bellinger <>
    Signed-off-by: Greg Kroah-Hartman <>
    nablio3000 committed with gregkh Aug 18, 2013
  16. iscsi-target: Fix ImmediateData=Yes failure regression in >= v3.10

    commit 9d86a2b upstream.
    This patch addresses a regression bug within ImmediateData=Yes failure
    handling that ends up triggering an OOPs within >= v3.10 iscsi-target
    The problem occurs when iscsit_process_scsi_cmd() does the call to
    target_put_sess_cmd(), and once again in iscsit_get_immediate_data()
    that is triggered during two different cases:
     - When iscsit_sequence_cmd() returns CMDSN_LOWER_THAN_EXP, for which
       the descriptor state will already have been set to ISTATE_REMOVE
       by iscsit_sequence_cmd(), and
     - When iscsi_cmd->sense_reason is set, for which iscsit_execute_cmd()
       will have already called transport_send_check_condition_and_sense()
       to queue the exception response.
    It changes iscsit_process_scsi_cmd() to drop the early call, and makes
    iscsit_get_immediate_data() call target_put_sess_cmd() from a single
    location after dumping the immediate data for the failed command.
    The regression was initially introduced in commit:
    commit 561bf15
    Author: Nicholas Bellinger <>
    Date:   Wed Jul 3 03:58:58 2013 -0700
        iscsi-target: Fix iscsit_sequence_cmd reject handling for iser
    Signed-off-by: Nicholas Bellinger <>
    Signed-off-by: Greg Kroah-Hartman <>
    nablio3000 committed with gregkh Aug 22, 2013
  17. target: Fix trailing ASCII space usage in INQUIRY vendor+model

    commit ee60bdd upstream.
    This patch fixes spc_emulate_inquiry_std() to add trailing ASCII
    spaces for INQUIRY vendor + model fields following SPC-4 text:
      "ASCII data fields described as being left-aligned shall have any
       unused bytes at the end of the field (i.e., highest offset) and
       the unused bytes shall be filled with ASCII space characters (20h)."
    This addresses a problem with Falconstor NSS multipathing.
    Reported-by: Tomas Molota <>
    Signed-off-by: Nicholas Bellinger <>
    Signed-off-by: Greg Kroah-Hartman <>
    nablio3000 committed with gregkh Jul 24, 2013
Commits on Sep 2, 2013
  1. Linux 3.11

    torvalds committed Sep 2, 2013
  2. Merge tag 'scsi-fixes' of git://…

    Pull SCSI fix from James Bottomley:
     "This is a bug fix for the pm80xx driver.  It turns out that when the
      new hardware support was added in 3.10 the IO command size was kept at
      the old hard coded value.  This means that the driver attaches to some
      new cards and then simply hangs the system"
    * tag 'scsi-fixes' of git://
      [SCSI] pm80xx: fix Adaptec 71605H hang
    torvalds committed Sep 2, 2013
  3. Merge branch 'x86-urgent-for-linus' of git://…

    Pull x86 boot fix from Peter Anvin:
     "A single very small boot fix for very large memory systems (> 0.5T)"
    * 'x86-urgent-for-linus' of git://
      x86/mm: Fix boot crash with DEBUG_PAGE_ALLOC=y and more than 512G RAM
    torvalds committed Sep 2, 2013
  4. Merge branch 'fixes' of git://

    Pull slave-dma fix from Vinod Koul:
     "A fix for resolving TI_EDMA driver's build error in allmodconfig to
      have filter function built in""
    * 'fixes' of git://
      dma/Kconfig: TI_EDMA needs to be boolean
    torvalds committed Sep 2, 2013
Commits on Aug 31, 2013
  1. Merge git://

    Pull networking fixes from David Miller:
     1) There was a simplification in the ipv6 ndisc packet sending
        attempted here, which avoided using memory accounting on the
        per-netns ndisc socket for sending NDISC packets.  It did fix some
        important issues, but it causes regressions so it gets reverted here
        too.  Specifically, the problem with this change is that the IPV6
        output path really depends upon there being a valid skb->sk
        The reason we want to do this change in some form when we figure out
        how to do it right, is that if a device goes down the ndisc_sk
        socket send queue will fill up and block NDISC packets that we want
        to send to other devices too.  That's really bad behavior.
        Hopefully Thomas can come up with a better version of this change.
     2) Fix a severe TCP performance regression by reverting a change made
        to dev_pick_tx() quite some time ago.  From Eric Dumazet.
     3) TIPC returns wrongly signed error codes, fix from Erik Hugne.
     4) Fix OOPS when doing IPSEC over ipv4 tunnels due to orphaning the
        skb->sk too early.  Fix from Li Hongjun.
     5) RAW ipv4 sockets can use the wrong routing key during lookup, from
        Chris Clark.
     6) Similar to #1 revert an older change that tried to use plain
        alloc_skb() for SYN/ACK TCP packets, this broke the netfilter owner
        mark which needs to see the skb->sk for such frames.  From Phil
     7) BNX2x driver bug fixes from Ariel Elior and Yuval Mintz,
        specifically in the handling of virtual functions.
     8) IPSEC path error propagations to sockets is not done properly when
        we have v4 in v6, and v6 in v4 type rules.  Fix from Hannes Frederic
     9) Fix missing channel context release in mac80211, from Johannes Berg.
    10) Fix network namespace handing wrt.  SCM_RIGHTS, from Andy
    11) Fix usage of bogus NAPI weight in jme, netxen, and ps3_gelic
        drivers.  From Michal Schmidt.
    12) Hopefully a complete and correct fix for the genetlink dump locking
        and module reference counting.  From Pravin B Shelar.
    13) sk_busy_loop() must do a cpu_relax(), from Eliezer Tamir.
    14) Fix handling of timestamp offset when restoring a snapshotted TCP
        socket.  From Andrew Vagin.
    * git:// (44 commits)
      net: fec: fix time stamping logic after napi conversion
      net: bridge: convert MLDv2 Query MRC into msecs_to_jiffies for max_delay
      mISDN: return -EINVAL on error in dsp_control_req()
      net: revert 8728c54 ("net: dev_pick_tx() fix")
      Revert "ipv6: Don't depend on per socket memory for neighbour discovery messages"
      ipv4 tunnels: fix an oops when using ipip/sit with IPsec
      tipc: set sk_err correctly when connection fails
      tcp: tcp_make_synack() should use sock_wmalloc
      bridge: separate querier and query timer into IGMP/IPv4 and MLD/IPv6 ones
      ipv6: Don't depend on per socket memory for neighbour discovery messages
      ipv4: sendto/hdrincl: don't use destination address found in header
      tcp: don't apply tsoffset if rcv_tsecr is zero
      tcp: initialize rcv_tstamp for restored sockets
      net: xilinx: fix memleak
      net: usb: Add HP hs2434 device to ZLP exception table
      net: add cpu_relax to busy poll loop
      net: stmmac: fixed the pbl setting with DT
      genl: Hold reference on correct module while netlink-dump.
      genl: Fix genl dumpit() locking.
      xfrm: Fix potential null pointer dereference in xdst_queue_output
    torvalds committed Aug 31, 2013
  2. MAINTAINERS: change my DT related maintainer address

    Filtering capabilities on my work email are pretty much non-existent and this
    has turned out to be something of a firehose...
    Cc: Stephen Warren <>
    Cc: Rob Herring <>
    Cc: Olof Johansson <>
    Cc: Linus Walleij <>
    Signed-off-by: Ian Campbell <>
    Acked-by: Pawel Moll <>
    Acked-by: Mark Rutland <>
    Signed-off-by: Linus Torvalds <>
    Ian Campbell committed with torvalds Aug 30, 2013
  3. Merge tag 'sound-3.11' of git://…

    Pull sound fixes from Takashi Iwai:
     "This contains two Oops fixes (opti9xx and HD-audio) and a simple fixup
      for an Acer laptop.  All marked as stable patches"
    * tag 'sound-3.11' of git://
      ALSA: opti9xx: Fix conflicting driver object name
      ALSA: hda - Fix NULL dereference with CONFIG_SND_DYNAMIC_MINORS=n
      ALSA: hda - Add inverted digital mic fixup for Acer Aspire One
    torvalds committed Aug 31, 2013
Commits on Aug 30, 2013
  1. Merge tag 'fixes-for-linus' of git://…

    Pull ARM SoC fixes from Olof Johansson:
     "Two straggling fixes that I had missed as they were posted a couple of
      weeks ago, causing problems with interrupts (breaking them completely)
      on the CSR SiRF platforms"
    * tag 'fixes-for-linus' of git://
      arm: prima2: drop nr_irqs in mach as we moved to linear irqdomain
      irqchip: sirf: move from legacy mode to linear irqdomain
    torvalds committed Aug 30, 2013
  2. Merge branch 'drm-fixes' of git://

    Pull drm fixes from Dave Airlie:
     "Since we are getting to the pointy end, one i915 black screen on some
      machines, and one vmwgfx stop userspace ability to nuke the VM,
      There might be one or two ati or nouveau fixes trickle in before
      final, but I think this should pretty much be it"
    * 'drm-fixes' of git://
      drm/vmwgfx: Split GMR2_REMAP commands if they are to large
      drm/i915: ivb: fix edp voltage swing reg val
    torvalds committed Aug 30, 2013
  3. Merge branch 'for-linus' of git://…

    Pull input layer updates from Dmitry Torokhov:
     "Just a couple of new IDs in Wacom and xpad drivers, i8042 is now
      disabled on ARC, and data checks in Elantech driver that were overly
      relaxed by the previous patch are now tightened"
    * 'for-linus' of git://
      Input: i8042 - disable the driver on ARC platforms
      Input: xpad - add signature for Razer Onza Classic Edition
      Input: elantech - fix packet check for v3 and v4 hardware
      Input: wacom - add support for 0x300 and 0x301
    torvalds committed Aug 30, 2013
  4. net: fec: fix time stamping logic after napi conversion

    Commit dc97538 "net: fec: add napi support to improve proformance"
    converted the fec driver to the napi model. However, that commit
    forgot to remove the call to skb_defer_rx_timestamp which is only
    needed in non-napi drivers.
    (The function napi_gro_receive eventually calls netif_receive_skb,
    which in turn calls skb_defer_rx_timestamp.)
    This patch should also be applied to the 3.9 and 3.10 kernels.
    Signed-off-by: Richard Cochran <>
    Signed-off-by: David S. Miller <>
    richardcochran committed with davem330 Aug 30, 2013
  5. net: bridge: convert MLDv2 Query MRC into msecs_to_jiffies for max_delay

    While looking into MLDv1/v2 code, I noticed that bridging code does
    not convert it's max delay into jiffies for MLDv2 messages as we do
    in core IPv6' multicast code.
    RFC3810, 5.1.3. Maximum Response Code says:
      The Maximum Response Code field specifies the maximum time allowed
      before sending a responding Report. The actual time allowed, called
      the Maximum Response Delay, is represented in units of milliseconds,
      and is derived from the Maximum Response Code as follows: [...]
    As we update timers that work with jiffies, we need to convert it.
    Signed-off-by: Daniel Borkmann <>
    Cc: Linus Lüssing <>
    Cc: Hannes Frederic Sowa <>
    Signed-off-by: David S. Miller <>
    borkmann committed with davem330 Aug 29, 2013
  6. mISDN: return -EINVAL on error in dsp_control_req()

    If skb->len is too short then we should return an error.  Otherwise we
    read beyond the end of skb->data for several bytes.
    Signed-off-by: Dan Carpenter <>
    Signed-off-by: David S. Miller <>
    Dan Carpenter committed with davem330 Aug 29, 2013
  7. net: revert 8728c54 ("net: dev_pick_tx() fix")

    commit 8728c54 ("net: dev_pick_tx() fix") and commit
    b6fe83e ("bonding: refine IFF_XMIT_DST_RELEASE capability")
    are quite incompatible : Queue selection is disabled because skb
    dst was dropped before entering bonding device.
    This causes major performance regression, mainly because TCP packets
    for a given flow can be sent to multiple queues.
    This is particularly visible when using the new FQ packet scheduler
    with MQ + FQ setup on the slaves.
    We can safely revert the first commit now that 416186f
    ("net: Split core bits of netdev_pick_tx into __netdev_pick_tx")
    properly caps the queue_index.
    Reported-by: Xi Wang <>
    Diagnosed-by: Xi Wang <>
    Signed-off-by: Eric Dumazet <>
    Cc: Tom Herbert <>
    Cc: Alexander Duyck <>
    Cc: Denys Fedorysychenko <>
    Signed-off-by: David S. Miller <>
    Eric Dumazet committed with davem330 Aug 29, 2013
  8. Revert "ipv6: Don't depend on per socket memory for neighbour discove…

    …ry messages"
    This reverts commit 1f324e3.
    It seems to cause regressions, and in particular the output path
    really depends upon there being a socket attached to skb->sk for
    checks such as sk_mc_loop(skb->sk) for example.  See ip6_output_finish2().
    Reported-by: Stephen Warren <>
    Reported-by: Fabio Estevam <>
    Signed-off-by: David S. Miller <>
    davem330 committed Aug 30, 2013
  9. ipv4 tunnels: fix an oops when using ipip/sit with IPsec

    Since commit 3d7b46c (ip_tunnel: push generic protocol handling to
    ip_tunnel module.), an Oops is triggered when an xfrm policy is configured on
    an IPv4 over IPv4 tunnel.
    xfrm4_policy_check() calls __xfrm_policy_check2(), which uses skb_dst(skb). But
    this field is NULL because iptunnel_pull_header() calls skb_dst_drop(skb).
    Signed-off-by: Li Hongjun <>
    Signed-off-by: Nicolas Dichtel <>
    Signed-off-by: David S. Miller <>
    Li Hongjun committed with davem330 Aug 28, 2013
  10. tipc: set sk_err correctly when connection fails

    Should a connect fail, if the publication/server is unavailable or
    due to some other error, a positive value will be returned and errno
    is never set. If the application code checks for an explicit zero
    return from connect (success) or a negative return (failure), it
    will not catch the error and subsequent send() calls will fail as
    shown from the strace snippet below.
    socket(0x1e /* PF_??? */, SOCK_SEQPACKET, 0) = 3
    connect(3, {sa_family=0x1e /* AF_??? */, sa_data="\2\1\322\4\0\0\322\4\0\0\0\0\0\0"}, 16) = 111
    sendto(3, "test", 4, 0, NULL, 0)        = -1 EPIPE (Broken pipe)
    The reason for this behaviour is that TIPC wrongly inverts error
    codes set in sk_err.
    Signed-off-by: Erik Hugne <>
    Signed-off-by: David S. Miller <>
    Erik Hugne committed with davem330 Aug 28, 2013