Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphical user interface for RStudio for packaging #27

Closed
nuest opened this issue Nov 22, 2016 · 7 comments

Comments

@nuest
Copy link
Member

commented Nov 22, 2016

RStudio has some nice ways to create a GUI (when package is used in RStudio presumably), so when needing user input this could be handy

See RStudio Add-inns: https://rstudio.github.io/rstudioaddins/

@nuest nuest added the idea label Nov 22, 2016

@nuest nuest changed the title Add graphical user interface for RStudio Add graphical user interface for RStudio for packaging Dec 12, 2016

@nuest nuest moved this from Later to Backlog in containerit package development Jan 30, 2017

@nuest nuest moved this from Backlog to Later in containerit package development Feb 10, 2017

@smwindecker

This comment has been minimized.

Copy link

commented Nov 22, 2018

Hi @nuest - a group of us at ropensci oz unconference 2018 are going start hacking at a few issues on containerit, including this one! Our fork and issue branch is here: https://github.com/ropenscilabs/containerit/tree/Issue27_GUI. Let us know if you have any thoughts on this one.

@nuest

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2018

Thakns @smwindecker ! That's great! Apologies for not getting back to you sooner. I will take a look soon. I guess master...ropenscilabs:master replaces #134 ?

@smwindecker

This comment has been minimized.

Copy link

commented Dec 7, 2018

Hey @nuest, I ended up working on a separate part of this project. Can't tag Elise Gould for some reason but she led this team so I'll nudge her in person to check your question.

@egouldo

This comment has been minimized.

Copy link
Contributor

commented Dec 9, 2018

Thanks for alerting me to this @smwindecker. That's correct, @nuest!

@nuest nuest moved this from Backlog to Current sprint in containerit package development Feb 23, 2019

@nuest nuest moved this from Current sprint to In Progress in containerit package development Jul 19, 2019

@nuest

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

@nuest

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

@egouldo Thank you so much for your awesome contribution, and my sincere apologies it took me that long to get around and take a look. As you might see in the history, I didn't do any development on this package for quite a while, but now I'm pushing some things forward, including your UI!

I don't know how to repay your efforts, but do let me know if you have an idea. What I can do is give some feedback on your code @clairemiller (can't tag Mark ☹️ )

During my review of the code, I made some style changes and wording changes, and refactoring, see nuest@5d54092

  • I am not an experiences Shiny/Addin developer, so for easier understandability (thinking about future me) I used explicit labels for the functions
  • Capitalising Dockerfile
  • Spaces around =, space after , in function argument list, use <- for object assignments and = for argument assignments
  • use the same type of quote character (not mixing " and ')
  • added a file common.R to have one share place to reduce duplication of code statements, e.g. the volumes <- definition for file opening dialogs.
  • some aligning of function names (e.g. in addin.R)
  • use basename to get directory name instead of regex
  • Put shiny::stopApp() at the same spot in all event functions
  • rename script files

I created an issue to develop the UI further: #147 Let me know what you think!

Again: 👍 💯 ❤️ Thank you! 🚀

image

@nuest nuest closed this Jul 19, 2019

containerit package development automation moved this from In Progress to Done Jul 19, 2019

@nuest

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

@egouldo @clairemiller please check if I got your ORCIDs right in the DESCRIPTION file: https://github.com/o2r-project/containerit/blob/dev/DESCRIPTION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.