Add CLI option to switch true colors on/off #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows user to control if onefetch should attempt to write true colors to the terminal.
o2sh
approved these changes
Jan 12, 2021
Owner
o2sh
left a comment
o2sh
left a comment
There was a problem hiding this comment.
You're absolutely right, for those who like to play with their terminal's color scheme, this flag can come to be very handy.
My only suggestion would be to use --show-logo as a template for its declaration as the two flags seem to operate similarly.
Collaborator
Author
Nice catch! The args should definitely have consistent usage. Suggestions committed. |
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to control if onefetch should attempt to write true colors to the terminal.
I found myself wanting to turn off true colors when executing
onefetchso that the output would match my preferred color scheme, and figured that other users might want to do the same 🙂