Use mailmap bindings #453
Merged
Use mailmap bindings #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HallerPatrick
left a comment
HallerPatrick
left a comment
There was a problem hiding this comment.
This feels way cleaner! If there is no .mailmap, then this will behave like before right?
Owner
Author
I fixed it with e031a88. |
HallerPatrick
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion #447, I added the
.mailmapauthor matching which came out to be quite straightforward thanks to the git2-rs bindings - 9ba9533.I also changed the merging logic from "email" to "username + email" to comply with
git shortlog.