Show the 'Is Simulated' option as disabled when the collider is acting as a trigger. #14997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g as a trigger. Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
hultonha
approved these changes
Mar 8, 2023
|
Any chance you could include a screenshot in the description please @moraaar just for @o3de/sig-ui-ux to take a look at too. |
Signed-off-by: moraaar <moraaar@amazon.com>
cgalvan
approved these changes
Mar 8, 2023
mbalfour-amzn
approved these changes
Mar 8, 2023
| // m_dummyIsSimulated is used for EditContext only, it will always be false and read-only. | ||
| // It will be shown instead of the real m_isSimulated property when m_isTrigger is enabled, | ||
| // this way it'll be clear that when the collider is a trigger it won't be simulated. | ||
| bool m_dummyIsSimulated = false; |
There was a problem hiding this comment.
Can this be made const, or does that fail to work with the EditContext?
There was a problem hiding this comment.
I tried that first, it does fail to compile unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Show the 'Is Simulated' option as disabled when the collider is acting as a trigger, this way it'll be clear that when the collider is a trigger it won't be simulated.
How was this PR tested?
Checked 'Is Simulated' appears disabled when 'Is Trigger' is enabled in Primitive, Mesh and Shape collider components.