elements/leader.lua lua error with WoW5. #143

Closed
tukz opened this Issue Jul 31, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@tukz

tukz commented Jul 31, 2012

Hey haste, you forgot to add a condition in the update function of leader.lua for isLeader. You need to add a "not WoW5" condition in front of UnitIsPartyLeader(unit) else, on MoP, if the unit is not the leader, it try to execute UnitIsPartyLeader() which doesnt exist anymore in 5.0.

@tukz

This comment has been minimized.

Show comment
Hide comment
@tukz

tukz Jul 31, 2012

Same issue with leader TAG in tag.lua

tukz commented Jul 31, 2012

Same issue with leader TAG in tag.lua

@tukz

This comment has been minimized.

Show comment
Hide comment
@tukz

tukz Jul 31, 2012

and leaderlong tag :P

tukz commented Jul 31, 2012

and leaderlong tag :P

@tukz

This comment has been minimized.

Show comment
Hide comment
@tukz

tukz Jul 31, 2012

There is an issue as well with eclipsebar.lua. If the druid doesnt have any spec at all, it try to execute GetPrimaryTalentTree() which doesnt exist on 5.0. So a "not WoW5" condition is required here as well.

I didnt want to create another issue just for this so I just updated this one.

tukz commented Jul 31, 2012

There is an issue as well with eclipsebar.lua. If the druid doesnt have any spec at all, it try to execute GetPrimaryTalentTree() which doesnt exist on 5.0. So a "not WoW5" condition is required here as well.

I didnt want to create another issue just for this so I just updated this one.

@tukz

This comment has been minimized.

Show comment
Hide comment
@tukz

tukz Jul 31, 2012

Same issue with assistant, make sure you check for not WoW5 if you include UnitIsPartyLeader()

tukz commented Jul 31, 2012

Same issue with assistant, make sure you check for not WoW5 if you include UnitIsPartyLeader()

@haste

This comment has been minimized.

Show comment
Hide comment
@haste

haste Aug 12, 2012

Member

All should be fixed with:
be68b10
e0d45ae
b6e00c0
56a56ab

Member

haste commented Aug 12, 2012

All should be fixed with:
be68b10
e0d45ae
b6e00c0
56a56ab

@haste haste closed this Aug 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment