Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature: Arena Preparation #275
This adds support for arena preparation frames, a solution to #177.
By taking over the
That should cover most of the available features with the arena prep system, and it requires no additional setup for the layout (plug-n-play).
added a commit
this pull request
Jul 29, 2016
I would like request that instead of needing to change all the different elements etc, you could setup the arena frames in a single place. Because now you need to test if it's an arena preparation frame on all the elements on all units.
We only need to look for the event ARENA_PREP_OPPONENT_SPECIALIZATIONS which enables it and ARENA_OPPONENT_UPDATE which disables it. What I'm proposing is creating function which setups up the dummy frame when we got the information (ARENA_PREP_OPPONENT_SPECIALIZATIONS) and disables it when the arena starts.
By the way, I tested this and it seemed to work:)
The reason behind the changes to all the elements is because of several reasons:
What you are thinking of is a new system to handle this, and that is exactly what we don't want, we want it to be handled gracefully without needing additional work in the layouts.
Okay, I see your point(s). I just annoying taking care of all the custom elements postupdate in my layout without knowing what event caused it. But it would be nice to have the possibility to handle all this in a single function. Is there an ok way of making the line self:UpdateAllElements('ArenaPreparation', true) instead call a custom setup function? I could always hook it but seems abit needless. The oUF code is abit above my league to understand fully:p
Or maybe add the classic:
(self.ArenaPreparation or self.UpdateAllElements) (self, 'ArenaPreparation', true)
I did some testing for this with my rebased branch. It worked pretty well overall, but I noticed that the frames would not show during arena prep until a teammate enters.
This is honestly a bit of an edge case as it's only really an issue if you're queuing solo for skirmishes, but I figured I would mention it regardless.