This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
Support dc name for vinc profile mapping #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merge make sure you either request correct Ansible version or you add updated module which support this. |
|
Hi Ondra, by Ansible version do you mean in the build.sh file? |
|
No here: But the change must be merged and part of specific Ansible release. 2.6 was already released so the first release where it is possible is 2.6.1. |
|
done |
maorlipchuk
force-pushed
the
BZ1576934
branch
3 times, most recently
from
489fb03
to
9554382
Compare
There was a problem hiding this comment.
Looks ok, please put REAME.md to the library/ directory , something like we have here: https://github.com/oVirt/ovirt-ansible-cluster-upgrade/blob/master/library/README.md
machacekondra
approved these changes
Jul 17, 2018
Support DC name as part of vnic_profile mapping to support multiple networks. Bug-Url: https://bugzilla.redhat.com/1576934
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support DC name as part of vnic_profile mapping to support multiple
networks.
Bug-Url: https://bugzilla.redhat.com/1576934