Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fapolicy: add allow rule for vdsm-mom #181

Merged
merged 1 commit into from Mar 30, 2022
Merged

Conversation

hbraha
Copy link
Contributor

@hbraha hbraha commented Mar 23, 2022

currently, vdsm-mom service is blocked by one of the fapolciy rules,
adding an exception rule for the service.

Bug-Url: https://bugzilla.redhat.com/2015802

@hbraha hbraha requested a review from mwperina as a code owner March 23, 2022 13:55
@hbraha hbraha requested a review from tinez March 23, 2022 13:55
@michalskrivanek
Copy link
Member

I believe this should be integral part of vdsm. there's nothing dynamic...it should be just a static drop-in file that gets places there during vdsm rpm installation (same as rules themselves)

@tinez
Copy link
Member

tinez commented Mar 29, 2022

I believe this should be integral part of vdsm. there's nothing dynamic...

This is true right now, but generally it's easier to manipulate things on host deploy level than in RPM installation. I'd rather keep it here, but if you'd really like to ship it with the RPM it's fine too.

@sandrobonazzola
Copy link
Member

@hbraha Is there a reference BZ for this PR? Is this for 4.5.0? Or can it wait for 4.5.1?

@mwperina
Copy link
Member

/ost

currently, vdsm-mom service is blocked by one of the fapolciy rules,
adding an exception rule for the service.
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.0 milestone Mar 30, 2022
@mwperina mwperina merged commit 6854a76 into oVirt:master Mar 30, 2022
hbraha added a commit to hbraha/ovirt-engine that referenced this pull request Mar 30, 2022
previous patch[1] added an exclusion rule for vdsm-mom to fapolicy
but didn't check if the service is up and running before restarting it.

[1] oVirt#181
hbraha added a commit to hbraha/ovirt-engine that referenced this pull request Mar 30, 2022
previous patch[1] added an exclusion rule for vdsm-mom to fapolicy
but didn't check if the service is up and running before restarting it.

[1] oVirt#181
mwperina pushed a commit that referenced this pull request Mar 30, 2022
previous patch[1] added an exclusion rule for vdsm-mom to fapolicy
but didn't check if the service is up and running before restarting it.

[1] #181
@michalskrivanek
Copy link
Member

@hbraha @mwperina @almusil sadly this is broken on rhvh which doesn't have fapolicyd installed

please use a different condition than when: ansible_distribution == 'RedHat'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants