Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean cache before upgrading packages #517

Merged
merged 1 commit into from Jul 26, 2022
Merged

Clean cache before upgrading packages #517

merged 1 commit into from Jul 26, 2022

Conversation

dangel101
Copy link
Member

@dangel101 dangel101 requested a review from mwperina as a code owner July 6, 2022 12:12
sandrobonazzola
sandrobonazzola approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.2 milestone Jul 6, 2022
didib
didib approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@didib didib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we allow/document how to supply/set custom ansible vars? If so, it should be very easy to add 'when: not yum_do_not_clean_packages | bool' or something like that.

@mwperina
Copy link
Member

mwperina commented Jul 22, 2022 •
edited

Do we allow/document how to supply/set custom ansible vars? If so, it should be very easy to add 'when: not yum_do_not_clean_packages | bool' or something like that.

No, we don't have support for that, but I don't think it's worth the effort to add a generic support for that

@mwperina mwperina force-pushed the B2104408_/var/cachr/dnf/)fills_up branch from 07f3c58 to a958149 Compare July 26, 2022 12:13
@mwperina
Copy link
Member

/ost

@mwperina mwperina force-pushed the B2104408_/var/cachr/dnf/)fills_up branch from a958149 to 7be7cb4 Compare July 26, 2022 14:15
@mwperina
Copy link
Member

/ost

@mwperina mwperina merged commit fa581d2 into oVirt:master Jul 26, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina left review comments

@sandrobonazzola sandrobonazzola sandrobonazzola approved these changes

@didib didib didib approved these changes

@michalskrivanek michalskrivanek michalskrivanek approved these changes

Assignees

@dangel101 dangel101

Labels
None yet
Projects
None yet
Milestone
ovirt-4.5.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dangel101 @mwperina @sandrobonazzola @didib @michalskrivanek