Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

Improvements #11

Merged
merged 3 commits into from Dec 15, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
hyper-upgrade: remove --upgrade-to-rhv option
It might create a confusion to users or even jump upgrade
versions required.
  • Loading branch information
dougsland committed Dec 14, 2017
commit 0fc9fe2e74b10a6e01817524251addfdd4edc92c
11 changes: 3 additions & 8 deletions man/ovirt-engine-hyper-upgrade.8
Expand Up @@ -3,7 +3,6 @@
ovirt-engine-hyper-upgrade \- A tool to help users upgrade RHV Manager (RHVM)
.SH SYNOPSIS
ovirt-engine-hyper-upgrade.py [-h] [--backup] [--backup-dir BACKUP_DIR]
[--upgrade-to-rhv UPGRADE_TO_RHV]

.SH DESCRIPTION
The \fBovit-engine-hyper-upgrade\fP is a wrapper tool to automate RHV Manager upgrades.
Expand Down Expand Up @@ -36,10 +35,6 @@ Execute engine-backup before the upgrade
Directory where the engine-backup will save the backup file.
If not provided, it will use /tmp

.TP
.B --upgrade-to-rhv
Upgrade to specifc version of RHV

.SH LOGGING
See \fB/var/log/ovirt-engine/engine-hyper-upgrade.log

Expand All @@ -51,12 +46,12 @@ Upgrade through latest version, backup won't be created

Upgrade to version 4.1 creating a backup from engine, backup will be saved in /backup
.br
# ovirt-engine-hyper-upgrade --backup --backup-dir=/backup --upgrade-to-rhv=4.1
# ovirt-engine-hyper-upgrade --backup --backup-dir=/backup
.br

Upgrade to version 4.1, backup won't created
Upgrade only, backup won't created
.br
# ovirt-engine-hyper-upgrade --upgrade-to-rhv=4.1
# ovirt-engine-hyper-upgrade
.br

.SH BUGS
Expand Down
11 changes: 1 addition & 10 deletions src/ovirt-engine-hyper-upgrade
Expand Up @@ -496,12 +496,6 @@ def main():
'If not provided, it will use /tmp',
)

parser.add_argument(
'--upgrade-to-rhv',
nargs=1,
help='Upgrade to specifc version of RHV',
)

logger.debug('----------------------')
logger.debug('Starting')
logger.debug('----------------------')
Expand All @@ -525,10 +519,7 @@ def main():

u = UpgradeHelper()
for release in CHECK_RELEASES['repos']:
if args.upgrade_to_rhv is None:
version = u.detect_major_version_engine()
else:
version = ' '.join(args.upgrade_to_rhv)
version = u.detect_major_version_engine()

if release['version'] == version:
upgrade_supported = True
Expand Down