Updating virt-sparsify feature page parts related to iSCSI and NFS #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykaul
reviewed
Feb 22, 2018
| @@ -41,6 +41,18 @@ Added "Sparsify" button to Disks subtab of Virtual Machines main tab. This butto | |||
| * Cinder disks cannot be sparsified. | |||
| * Pre-allocated disks cannot be sparsified. `virt-sparsify` works on pre-allocated disks, but its usage is not justified for this case. User chooses pre-allocated option if she needs better performance, because no additional allocation and no fragmentation will occur when the disk is used. Deallocating some clusters as result of sparsification will overturn this advantage. If user wants to save space at cost of some performance decrease, she can select thin-provisioned option. | |||
| * Disks on NFS storage may be sparsified only if NFS version >= 4.2. | |||
| * For an iSCSI volume to be sparsified, support of both host kernel and the actual backing store is required. | |||
|
|
|||
| Also it depends on various SCSI flags reported by the device. These are contained in the SCSI "VPD" data. It might be interesting to run `sg_inq` and `sg_vpd` (from `sg3_utils`) on the device: | |||
There was a problem hiding this comment.
Rephrase 'Also it depends' to something like - you can verify this support via various SCSI flags...
* Adding note about bug 1489262 that prevents virt-sparsify from working on RHEL 7.4.
|
@ahadas - can you review and approve? |
|
I reviewed that and it looks good. The "Limitations" seem helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on NFS partitions under RHEL 7.4.
I confirm that this pull request was submitted according to the contribution guidelines: @smelamud
This pull request needs review by: @ahadas