Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example for importing template from ova #15

Merged
merged 1 commit into from Oct 14, 2021
Merged

Conversation

fjanuska
Copy link
Contributor

@fjanuska fjanuska commented Oct 5, 2021

No description provided.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow fix build version to 4.4.15 #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mwperina
Copy link
Member

mwperina commented Oct 5, 2021

ci add to whitelist

@mwperina mwperina requested review from mnecas and oliel October 5, 2021 16:40
@ahadas
Copy link
Member

ahadas commented Oct 7, 2021

lgtm
@fjanuska I see that you don't specify the provider like we do in the example of importing a vm from ova - if it works that way, can you please also remove it there (in a separate PR)? that's something a user was confused about in the users list couple of days ago
cc @liranr23, @vjuranek

@mwperina
Copy link
Member

ci test

2 similar comments
@mwperina
Copy link
Member

ci test

@mwperina
Copy link
Member

ci test

Copy link
Collaborator

@oliel oliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks fine to me, I'll approve it as soon as we find out why CI fails

@mwperina
Copy link
Member

ci test

@oliel oliel merged commit 72edb70 into oVirt:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants