Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Black berry #19

Merged
merged 2 commits into from Oct 25, 2011

Conversation

Projects
None yet
2 participants
Contributor

joatis commented Oct 25, 2011

I added Blackberry to the list of possible return values of browser_string() and added 2 new user_agents to the useragents.json file. There are 2 commits because I'd forgotten to update the documentation the first time.

John Oatis

joatis added some commits Oct 25, 2011

@joatis joatis Added "BlackBerry" to browser_string()
Added "BlackBerry" to the list of possible browser strings. Also added
new BlackBerry 6.0 UA string that contains WebKit/Safari tokens to
useragents.json
fbbed1e
@joatis joatis Updated browser_string() documentation.
Added BlackBerry to the list of possible return values of
sub browser_string.
db8fa74

@oalders oalders added a commit that referenced this pull request Oct 25, 2011

@oalders oalders Merge pull request #19 from joatis/BlackBerry
Black berry
848e5b6

@oalders oalders merged commit 848e5b6 into oalders:master Oct 25, 2011

Owner

oalders commented Oct 25, 2011

First off, thanks for this. :) I just ran the tests and I'm getting a warning "Subroutine HTTP::BrowserDetect::blackberry redefined " when run "dzil test". Could you have a look at that and see if you can clear up the warning?

Contributor

joatis commented Oct 25, 2011

Will do. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment