Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Removed Duplicate blackberry from @ALL_TESTS #20

Merged
merged 1 commit into from

2 participants

@joatis

When adding Blackberry to the list of possible browser strings I had
added 'blackberry' to the push section of @ALL_TESTS marked #Browsers.
This led to a warning that an existing reference was
being redefined. Removing the duplicate 'blackberry' from @ALL_tests
(it is pushed earlier in #devices section) removes the warning.
browser_string() will still returns 'BlackBerry' now
using only the single instance of 'blackberry' within @ALL_TESTS.

@joatis joatis Removed Duplicate blackberry from @ALL_TESTS
When adding Blackberry to the list of possible browser strings I had
added 'blackberry' to the push section of @ALL_TESTS marked #Browsers.
This led to a warning that an existing reference was
being redefined. Removing the duplicate 'blackberry' from @ALL_tests
(it is pushed earlier in #devices section) removes the warning.
browser_string() will still returns 'BlackBerry' now
using only the single instance of 'blackberry' within @ALL_TESTS.
c345360
@oalders oalders merged commit 1ded168 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 27, 2011
  1. @joatis

    Removed Duplicate blackberry from @ALL_TESTS

    joatis authored
    When adding Blackberry to the list of possible browser strings I had
    added 'blackberry' to the push section of @ALL_TESTS marked #Browsers.
    This led to a warning that an existing reference was
    being redefined. Removing the duplicate 'blackberry' from @ALL_tests
    (it is pushed earlier in #devices section) removes the warning.
    browser_string() will still returns 'BlackBerry' now
    using only the single instance of 'blackberry' within @ALL_TESTS.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/HTTP/BrowserDetect.pm
View
2  lib/HTTP/BrowserDetect.pm
@@ -58,7 +58,7 @@ push @ALL_TESTS, qw(
aol6 neoplanet neoplanet2
avantgo emacs mozilla
r1 elinks netfront
- mobile_safari blackberry
+ mobile_safari
);
# Engines
Something went wrong with that request. Please try again.