Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/lint errors #71

Merged
merged 2 commits into from Jul 17, 2020
Merged

fix/lint errors #71

merged 2 commits into from Jul 17, 2020

Conversation

fellipeh
Copy link
Contributor

@fellipeh fellipeh commented Jun 2, 2020

These PR will

  • Fix py26 and py27 lint errors
  • Add make lint to run lint on local machine
  • Add make lint-errors to run lint on local machine and show only errors

Signed-off-by: Fellipe Henrique fpedrosa@redhat.com

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable @oamg/convert2rhel
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

.pylintrc Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@fellipeh fellipeh marked this pull request as ready for review June 8, 2020 11:34
@fellipeh fellipeh force-pushed the fix/lint-errors branch 20 times, most recently from 3a66cd8 to 8a770da Compare June 10, 2020 13:23
@fellipeh
Copy link
Contributor Author

fellipeh commented Jun 19, 2020

Created ticket for infra team to loo at these issue.

Makefile Outdated Show resolved Hide resolved
.github/workflows/pylint.yml Outdated Show resolved Hide resolved
.github/workflows/pylint.yml Outdated Show resolved Hide resolved
.github/workflows/pylint.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@fellipeh
Copy link
Contributor Author

fellipeh commented Jun 22, 2020

Thanks @RheaAyase very much... you are right, and now it's works!

@fellipeh
Copy link
Contributor Author

/packit build

@fellipeh fellipeh changed the title [WIP] fix/lint errors fix/lint errors Jun 23, 2020
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
convert2rhel/systeminfo.py Outdated Show resolved Hide resolved
convert2rhel/unit_tests/pkghandler_test.py Outdated Show resolved Hide resolved
convert2rhel/unit_tests/pkghandler_test.py Outdated Show resolved Hide resolved
convert2rhel/unit_tests/pkghandler_test.py Outdated Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
@fellipeh
Copy link
Contributor Author

@bocekm this PR is ready to merge?

@bocekm bocekm merged commit 9a971f4 into oamg:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants