Rework the NetworkManagerUpdateClientId actor (v2) #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengal
force-pushed
the
nm2
branch
7 times, most recently
from
34c921b
to
276d461
Compare
It seems better to use a more generic name, so that in the future the actor could also handle other changes to connections.
The helper script to update client-ids needs a python D-Bus library which is only available for Python 3 in the new system. Therefore, explicitly run the script through the python3 interpreter. Also, the script needs to be called when NetworkManager is running and so move the actor to the FirstBoot phase.
bengal
changed the title
|
Sorry, I couldn't test the PR because upgrade using the vagrant box fails (even without my PR): https://gist.github.com/bengal/6df10c10b4d9ae292cc0b4f944a6062d |
|
@bengal please update the vagrant box, we just merged a fix for this error |
It works now, thanks! |
|
leapp-ci build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the external tool code into a library and convert it to use nmcli instead of the GObject introspection library.
See also #69