Rename "filename" to "name" in ActiveKernelModule model (closes issue #47) #169
Conversation
There was a problem hiding this comment.
When you change filename to name, make sure that you do not break any other existing actors.
Your change breaks checkbtrfs actor, because it still uses filename.
https://github.com/oamg/leapp-repository/blob/master/repos/system_upgrade/el7toel8/actors/checkbtrfs/actor.py
https://github.com/oamg/leapp-repository/blob/master/repos/system_upgrade/el7toel8/actors/checkbtrfs/tests/test_btrfs.py
Please make changes to checkbtrfs actors as well.
examon
changed the title
|
Additionally, fix commit message: https://chris.beams.io/posts/git-commit/ |
|
@pirat89 Close this one? It looks like it is not moving forward. |
|
No no. I will work on this. |
|
@seenivasanseeni regarding the changes we made in the meantime, rebase the branch against upstream master please. You will have better clue about results of the tests then. |
Please make sure, that you use request review each time you make changes in your code, so the reviewer will be notified about your request |
|
This PR has been linked in issue tracker (#RHELLEAPP-1736) |
|
@seenivasanseeni, do you plan to do the requested changes? |
|
Since the branch has moved further, I will start fresh from the new master. I am gonna close this PR. |
renamed filename to name in ActiveKernelModule implementation and usage of that class