Skip to content

Conversation

@andywaltlova
Copy link
Collaborator

@andywaltlova andywaltlova commented Apr 4, 2024

HMS-3843

This is aimed to give users possibility to pass additional variables to script execution environment through same config as worker uses.

If rhcd passes additional variables then so be it, these will get appended to the execution environment on top of them.

Signed-off-by: Andrea Waltlova <awaltlov@redhat.com>
@andywaltlova andywaltlova requested a review from r0x0d April 9, 2024 08:34
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small logging typo

Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.88%. Comparing base (a62be18) to head (6aa1fca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   65.06%   65.88%   +0.82%     
==========================================
  Files           5        5              
  Lines         249      255       +6     
==========================================
+ Hits          162      168       +6     
  Misses         67       67              
  Partials       20       20              
Flag Coverage Δ
go-1.19 65.88% <100.00%> (+0.82%) ⬆️
go-1.20 65.88% <100.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d merged commit 8745a74 into oamg:main Apr 9, 2024
@r0x0d r0x0d mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants