Fix: Rename category embark-selected to embark-selected-overlay #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the face property added by `defface embark-selected' conflicts with the overlay category properties.
minad
added a commit
to minad/jinx
that referenced
this pull request
Apr 30, 2023
|
Oh, thank goodness you figured this out. It was driving me a little crazy. |
|
Yes, this pattern is actually more dangerous than I initially thought. |
|
Thanks for the quick merge! |
|
No, thank you for the fix! Sometimes the selection overlay wasn't displaying at all despite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the face property added by
defface embark-selectedconflicts with the overlay category properties. This leads to very weird errors in the messages buffer likeInvalid face reference: 1234and the overlays are not displayed properly.