New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 #75

Merged
merged 4 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@clenk
Contributor

clenk commented Oct 15, 2018

No description provided.

clenk added some commits Oct 15, 2018

@emmanvg

Ran the tests on my side. Everything looks fine. If anything, on the tox.ini I would leave isort-check and packaging on 3.6 until we have a stable stable build for 3.7

Keep isort/packaging checks on Py3.6
...until Travis sorts out its 3.7 support.
@codecov-io

This comment has been minimized.

codecov-io commented Oct 16, 2018

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          31       31           
  Lines        2857     2857           
=======================================
  Hits         2709     2709           
  Misses        148      148
Impacted Files Coverage Δ
stix2validator/enums.py 93.89% <100%> (ø) ⬆️
stix2validator/shoulds.py 94.67% <100%> (ø) ⬆️
stix2validator/musts.py 94.32% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 024fd25...2a4b98e. Read the comment docs.

@clenk clenk merged commit 15a96e2 into master Oct 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@clenk clenk deleted the python3.7 branch Oct 16, 2018

@clenk clenk added this to the 1.1.0 milestone Oct 16, 2018

@clenk clenk self-assigned this Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment