Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning the number of results is not explicitly clear #42

Closed
jordan2175 opened this issue Feb 15, 2018 · 4 comments
Closed

Returning the number of results is not explicitly clear #42

jordan2175 opened this issue Feb 15, 2018 · 4 comments

Comments

@jordan2175
Copy link

@jordan2175 jordan2175 commented Feb 15, 2018

In the 2.0 specification we talk about the server returning the total number of results. It is felt that this is not super clear. Does this mean the number of records in the collection or the number of records that match a certain query. All it says is "in a result set". If we keep this in our new pagination style, when that is designed, it should probably be made to be optional and it should probably be the total number of objects / items in the collection, not the number of objects that match the current filtered query.

@MarkDavidson
Copy link

@MarkDavidson MarkDavidson commented Feb 20, 2018

Can this issue be clarified? I'm not clear on what it means. Perhaps something like "Text describing number of results is unclear", and a link to or quotation of the unclear text.

Loading

@jordan2175
Copy link
Author

@jordan2175 jordan2175 commented Feb 20, 2018

We discussed this on the working call on 2018-02-20 with the following 15 TC members (Bret Jordan, Trey Darley, Chris Ricard, Christian Hunt, Dan Dye, Dave Lemire, Drew Varner, Efrain Ortiz, Gary Katz, Jane Ginn, John-Mark Gurney, John Wunder, Nicholas Hayden, Paul Patrick, Rich Piazza). The consensus on the call was that it probably should be the number of objects that match the query or filter that was provided. However, we need to do some more investigation on this once we redo our pagination style. I think if we do keep this, with our pagination changes, then we should probably make it optional for the server to implement.

Loading

@jordan2175 jordan2175 added this to the TAXII-2.1-CSD01 milestone Feb 22, 2018
@jordan2175 jordan2175 added this to To do in TAXII-2.1 Feb 22, 2018
@jordan2175
Copy link
Author

@jordan2175 jordan2175 commented Feb 23, 2018

Based on the current discussions about pagination, this may not actually be an issue going forward.

Loading

@jordan2175 jordan2175 removed this from the 2.1-CSD01-WD01 milestone Apr 11, 2018
@jordan2175 jordan2175 added this to the 2.1-CSD01-WD02 milestone Apr 11, 2018
@jordan2175 jordan2175 removed this from the 2.1-CSD01-WD02 milestone Apr 16, 2018
@jordan2175
Copy link
Author

@jordan2175 jordan2175 commented Jan 22, 2019

The pagination style we have implemented in TAXII 2.1 does not use this feature. So this can be closed.

Loading

@jordan2175 jordan2175 closed this Jan 22, 2019
@jordan2175 jordan2175 added this to the 2.1-CSD02-WD06 milestone Jan 22, 2019
@jordan2175 jordan2175 moved this from To do to Done in TAXII-2.1 Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
TAXII-2.1
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants