Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address corner case for generated files in run.files dictionary #125

Closed
lgolding opened this issue Mar 14, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@lgolding
Copy link
Contributor

commented Mar 14, 2018

Some tools rewrite the same file multiple times, and analyze it each time. How do we represent that file in the files dictionary?

@michaelcfanning

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2018

One way to address this would simply be to require use of a urlBaseId and to generate a unique one every time a file is regenerated. This would result in a unique entry in the files table.

@michaelcfanning michaelcfanning changed the title Address corner case in run.files dictionary Address corner case for generated files in run.files dictionary Mar 18, 2018

@lgolding

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2018

I agree it's not hard to figure out how to represent such a repeatedly-rewritten file in the run.files dictionary. The problem this scenario raises is how a viewer can present the various incarnations of the file, when only the most recent one actually exists on disk. I need to know more about how tools use these repeatedly-rewritten files. For example: if a tool scans version 1 of such a file, finds a result, rewrites the file, rescans it, and finds a second result, what's the viewer to do when the user double-clicks on the first result?

@lgolding

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

@michaelcfanning @kupsch Jim, was this your issue originally, or was it Paul's? Please see my comment/question above... is there really anything we can do about this?

lgolding added a commit that referenced this issue Apr 17, 2018

@lgolding lgolding self-assigned this Apr 19, 2018

@lgolding

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2018

Fixed by 0401f51.

@lgolding lgolding closed this Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.