New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result.fingerprints array #126

Closed
lgolding opened this Issue Mar 14, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@lgolding
Contributor

lgolding commented Mar 14, 2018

Post-processing tools or result management systems might take the result.fingerprintContributions, combine them with other information in the SARIF file, and create one or more fully computed fingerprints. We need a place to put them.

We might also address this by making result.id an array.

I labeled this a breaking change out of caution. If we just add result.computedFingerprints, it's not breaking. If we change run.id to an array, it's breaking.

@lgolding lgolding changed the title from Add run.computedFingerprints array to Add result.computedFingerprints array Apr 1, 2018

@lgolding lgolding self-assigned this Apr 5, 2018

@lgolding

This comment has been minimized.

Show comment
Hide comment
@lgolding

lgolding Apr 5, 2018

Contributor

@michaelcfanning As we discussed: We'll leave result.id alone as a result-management-system-generated unique identifier, and add result.computedFingerprints just for fingerprints. So, it's not a breaking change.

Contributor

lgolding commented Apr 5, 2018

@michaelcfanning As we discussed: We'll leave result.id alone as a result-management-system-generated unique identifier, and add result.computedFingerprints just for fingerprints. So, it's not a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment