Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serde[-cbor] with borsh #242

Merged
merged 15 commits into from Nov 13, 2019
Merged

Replace serde[-cbor] with borsh #242

merged 15 commits into from Nov 13, 2019

Conversation

@nhynes
Copy link
Member

nhynes commented Nov 6, 2019

this constitutes the alpha of v0.3, which will also include a more explicit dispatch step (so it's not yet a release)

nhynes added 13 commits Nov 4, 2019
@nhynes nhynes requested review from eauge and peterjgilbert Nov 12, 2019
Cargo.toml Outdated Show resolved Hide resolved
@eauge
eauge approved these changes Nov 12, 2019
@rebekahkim

This comment has been minimized.

Copy link
Contributor

rebekahkim commented Nov 13, 2019

How will this affect other services using serde::Serialize/Deserialize retroactively?

@nhynes

This comment has been minimized.

Copy link
Member Author

nhynes commented Nov 13, 2019

How will this affect other services using serde::Serialize/Deserialize retroactively?

v0.2 and v0.3 services are totally incompatible, but that's captured in the semver bump. existing services will continue to work, of course

tests/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

peterjgilbert left a comment

Mirror borsh in oasislabs org, otherwise LGTM

@nhynes nhynes merged commit 9ad1bdb into master Nov 13, 2019
8 checks passed
8 checks passed
ci/circleci: build_standalone_examples Your tests passed on CircleCI!
Details
ci/circleci: clippy Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: init Your tests passed on CircleCI!
Details
ci/circleci: test_idl Your tests passed on CircleCI!
Details
ci/circleci: test_imports Your tests passed on CircleCI!
Details
ci/circleci: wasm_build Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 86.582%
Details
@nhynes nhynes deleted the borsh branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.