Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change author url to feedback@ #98

Merged
merged 1 commit into from May 31, 2019

Conversation

@nhynes
Copy link
Collaborator

commented May 31, 2019

No description provided.

@nhynes nhynes requested a review from naheed May 31, 2019

@@ -1,7 +1,7 @@
[package]
name = "bcfs"
version = "0.1.0"
authors = ["Oasis Labs <info@oasislabs.com>"]

This comment has been minimized.

Copy link
@willscott

willscott May 31, 2019

Collaborator

we use info@ consistently throughout all other open code. where does feedback go / why inconsistency?

This comment has been minimized.

Copy link
@nhynes

nhynes May 31, 2019

Author Collaborator

info@ is output only. We want developers to feel like they can provide input. Hence @feedback. @naheed came up with idea; I think it's good. Nobody actually would use the email over github, but it has the right ethos.

This comment has been minimized.

Copy link
@naheed

naheed May 31, 2019

Contributor

will - trying to change info to feedback. In last docs push, we have also changed all dev specific email aliases to feedback@

@naheed
naheed approved these changes May 31, 2019

@naheed naheed merged commit 68fd643 into master May 31, 2019

6 checks passed

ci/circleci: init Your tests passed on CircleCI!
Details
ci/circleci: test_examples Your tests passed on CircleCI!
Details
ci/circleci: test_idl Your tests passed on CircleCI!
Details
ci/circleci: test_xcc Your tests passed on CircleCI!
Details
ci/circleci: unit_test Your tests passed on CircleCI!
Details
ci/circleci: wasm_build Your tests passed on CircleCI!
Details
nhynes added a commit that referenced this pull request May 31, 2019

@nhynes nhynes deleted the change-author-url branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.