Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/wallet): Trim 0x when importing secp256k1 #231

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(cmd/wallet): Trim 0x when importing secp256k1 #231

merged 1 commit into from
May 8, 2024

Conversation

amela
Copy link
Member

@amela amela commented May 8, 2024 •
edited by matevz
Loading

Fixes #106

@amela amela requested review from matevz and kostko May 8, 2024 07:43
@amela amela linked an issue May 8, 2024 that may be closed by this pull request
Trim 0x when importing secp256k1 private key #106
Closed
@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 66ffb88
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/663b380ca2e9030008693978

@amela amela force-pushed the amela/fix/trim-0x-when-importing-secp256k1 branch from 9b28012 to 29dfc12 Compare May 8, 2024 07:44
kostko
kostko reviewed May 8, 2024
View reviewed changes
wallet/file/file.go Outdated Show resolved Hide resolved
kostko
kostko reviewed May 8, 2024
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add an example to examples/ so this code path is tested.

@amela amela force-pushed the amela/fix/trim-0x-when-importing-secp256k1 branch 2 times, most recently from fdea2b2 to 293e366 Compare May 8, 2024 08:04
@amela amela force-pushed the amela/fix/trim-0x-when-importing-secp256k1 branch 4 times, most recently from 6bc50bf to d8872fc Compare May 8, 2024 08:24
kostko
kostko reviewed May 8, 2024
View reviewed changes
wallet/file/file.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/fix/trim-0x-when-importing-secp256k1 branch from d8872fc to 66ffb88 Compare May 8, 2024 08:30
@amela amela requested a review from kostko May 8, 2024 08:34
@amela amela merged commit 750f8d6 into master May 8, 2024
4 checks passed
@amela amela deleted the amela/fix/trim-0x-when-importing-secp256k1 branch May 8, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@matevz matevz Awaiting requested review from matevz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim 0x when importing secp256k1 private key
3 participants
@amela @matevz @kostko