Avoid web usb permission issue in the latest Chrome #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buberdds
requested review from
lukaw3d,
pro-wh,
peterjgilbert,
kostko and
tjanez
as code owners
|
lukaw3d
approved these changes
Mar 16, 2023
buberdds
force-pushed
the
mz/webusb
branch
2 times, most recently
from
a3f8520
to
96622a6
Compare
|
For completeness, using the current version of the extension (1.9.0) to open an account on the Ledger hardware wallet with Chrome/Chromium version 110 (and other browsers based on this codebase, e.g. Brave) makes the browser crash. For more info, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Chrome update (not confirmed yet) users cannot use Ledger to open a wallet due to limitation around popup windows and web usb API. PR created in case we won't find anything else soon. Tab is opened only when usb permissions are missing. Once permissions are granted user won't leave extension popup context.