New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notice before staking to top 20 validators to encourage decentralization #831
Conversation
cc51158
to
47a3cbc
Compare
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 87.95% 87.88% -0.08%
==========================================
Files 101 101
Lines 1627 1634 +7
Branches 333 337 +4
==========================================
+ Hits 1431 1436 +5
- Misses 196 198 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
<p> | ||
{t( | ||
'account.addEscrow.confirmDelegatingToTop.description', | ||
'This validator is ranked in the top 20 by stake. Please consider delegating to a smaller validator to increase network security and decentralization.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess more of a copy question for product, but my first instinct is the softer approach of prodding the user through giving them context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's fine :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as is and work on improving copy in a subsequent PR if necessary 🙂
d370b6e
to
d4e3b79
Compare
d4e3b79
to
a4ee663
Compare
Mitigates #766