Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notice before staking to top 20 validators to encourage decentralization #831

Merged
merged 1 commit into from May 26, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 18, 2022

Mitigates #766

notice

@github-actions
Copy link

github-actions bot commented May 18, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.02s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 1.17s
✅ JSON jsonlint 1 0 0.32s
✅ JSON prettier 1 0 0 0.74s
✅ JSON v8r 1 0 1.17s
✅ TSX eslint 3 0 0 6.12s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #831 (a4ee663) into master (52809a5) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   87.95%   87.88%   -0.08%     
==========================================
  Files         101      101              
  Lines        1627     1634       +7     
  Branches      333      337       +4     
==========================================
+ Hits         1431     1436       +5     
- Misses        196      198       +2     
Flag Coverage Δ
cypress 57.45% <0.00%> (-0.26%) ⬇️
jest 74.72% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...akingPage/Features/ValidatorList/ValidatorItem.tsx 85.71% <0.00%> (ø)
src/app/components/AddEscrowForm/index.tsx 92.30% <75.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52809a5...a4ee663. Read the comment docs.

src/app/components/AddEscrowForm/__tests__/index.test.tsx Outdated Show resolved Hide resolved
<p>
{t(
'account.addEscrow.confirmDelegatingToTop.description',
'This validator is ranked in the top 20 by stake. Please consider delegating to a smaller validator to increase network security and decentralization.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess more of a copy question for product, but my first instinct is the softer approach of prodding the user through giving them context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's fine :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as is and work on improving copy in a subsequent PR if necessary 🙂

@lukaw3d lukaw3d merged commit 9fa4e19 into master May 26, 2022
@lukaw3d lukaw3d deleted the lw/notice-top-validators branch May 26, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants