Feature/tr 1252 handle stalled event

[btamas]

Related to https://oat-sa.atlassian.net/browse/TR-1252

• Listen to video stalled state
• Show button to make video reloadable by user
• Tests for stalled behavior

Test:

• Have an item with media interaction and have another one with media player shared stimulus
• Play video from CDN and disconnect
• You should see a message and reload button that reloads the video when you are online again
• You should not see the message when your internet is on, but it is slow

[marpesia]

If I block the URL of the media, it returns a general error and goes back to the list of tests. That's correct?

[btamas]

If I block the URL of the media, it returns a general error and goes back to the list of tests. That's correct?

I think yes, because the item is not loaded correctly, so it is on the item level not on the interaction level.

[marpesia]

Approved

[marpesia]

Great job! Very detail :)

Review Checklist

• New code is covered by tests (if applicable)
• Tests are running successfully (old and new ones) on my local machine (if applicable)
• New code is respecting code style rules
• New code is respecting best practices
• New code is not subject to concurrency issues (if applicable)
• Feature is working correctly on my local machine (if applicable)
• Acceptance criteria are respected
• Pull request title and description are meaningful
• Pull request's target is not master
• Commits are following conventional commits
• Commits messages are meaningful
• Commits are atomic
• Changelog is updated according to changes (if applicable)
• Documentation is updated according to changes (if applicable)

[jsconan]

The code looks good, nice work.

Unfortunately, I was not able to fully test the feature.

I have 2 small comments, but not blocking

Review Checklist

• New code is covered by tests (if applicable)
• Tests are running successfully (old and new ones) on my local machine (if applicable)
• New code is respecting code style rules
• New code is respecting best practices
• New code is not subject to concurrency issues (if applicable)
• Feature is working correctly on my local machine (if applicable)
• Acceptance criteria are respected
• Pull request title and description are meaningful
• Pull request's target is not master
• Commits are following conventional commits
• Commits messages are meaningful
• Commits are atomic
• Changelog is updated according to changes (if applicable)
• Documentation is updated according to changes (if applicable)

[jsconan]

question: no other way that setting it in pixels? How will it present on devices with high DPI or devices with huge resolution?

[meefox]

actually, it should not be a problem we have conversion for this case sure it could be rem / em

[btamas]

I checked how the icon was implemented, and it was pixels, so I used pixels to overwrite them.

[meefox]

Looking good, please check small notes from JS.

Review Checklist

• New code is covered by tests (if applicable)
• Tests are running successfully (old and new ones) on my local machine (if applicable)
• New code is respecting code style rules
• New code is respecting best practices
• New code is not subject to concurrency issues (if applicable)
• Feature is working correctly on my local machine (if applicable)
• Acceptance criteria are respected
• Pull request title and description are meaningful
• Pull request's target is not master
• Commits are following conventional commits
• Commits messages are meaningful
• Commits are atomic
• Changelog is updated according to changes (if applicable)
• Documentation is updated according to changes (if applicable)