Won't build for iOS 8 or older

[david-novak-legrand]

Hi @lganzzzo,

I'm working on the iOS app version of the Android app that @dmcamens-legrand discussed with you recently. The oat++ library is working well on Android now, and I'm trying to make it work on iOS as well.

Sadly, the even though the thread_local keyword was added to Xcode 8, it won't compile to devices running iOS 8 or earlier, even in the current version (Xcode 10).

Do you have any ideas for how to use this library without using the thread_local storage functionality from C++11?

Thank you!

[lganzzzo]

Hello @david-novak-legrand ,

I have to investigate possible ways to work around this problem.

Will get back to you shortly.

Best Regards,
Leonid

[david-novak-legrand]

Thank you!

[lganzzzo]

Hey @david-novak-legrand ,

Please checkout this branch https://github.com/oatpp/oatpp/tree/compat_build_no_thread_local

Just build oatpp with -DOATPP_COMPAT_BUILD_NO_THREAD_LOCAL flag in order to build without thread_local.

cmake -DOATPP_COMPAT_BUILD_NO_THREAD_LOCAL=ON ..

Do you also need to be able to build oatpp-websocket module without thread_local ?
What other oatpp modules you are planning to use?

Regards,
Leonid

[lganzzzo]

Hello @david-novak-legrand , @dmcamens-legrand ,

Please checkout:

• oatpp branch - compat_build_no_thread_local
• oatpp-websocket branch compat_build_no_thread_local

Rebuild both oatpp and oatpp-websocket modules with -DOATPP_COMPAT_BUILD_NO_THREAD_LOCAL flag:

cmake -DOATPP_COMPAT_BUILD_NO_THREAD_LOCAL=ON ..

Please let me know if it worked for you.
Branches will be merged after you confirmation.

Best Regards,
Leonid

[lganzzzo]

Hello @david-novak-legrand ,
Did you manage to build oatpp from specified branch for iOS8 ?

[david-novak-legrand]

Hi @lganzzzo ,
Thanks for your help! I believe it's close. I'm running into issues compiling some of the implicit conversions from long long to size_t.

[lganzzzo]

@david-novak-legrand. Cool, please let me know if you need some help from my side.
Also it would be cool if you prepare a PR with your "compatibility" changes!

Thank you.

[david-novak-legrand]

@lganzzzo Just got it to build! I would be very happy to prepare a PR.

Thanks!

[lganzzzo]

nice!

[david-novak-legrand]

I noticed that you removed three files under commit 71630b6 (Better Router API):
Router.cpp
Subscriber.hpp
Subscriber.cpp

I'm not sure what required them, but I had to re-add them for it to build.

Any idea what might still require those files?