Upgrade rubocop-rspec to version 1.26.0 #388
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and all tests pass. \o/
You should probably take a good look at this before merging this pull request, of course.
What changed?
✳️ rubocop-rspec ( → 1.26.0) · Repo · Changelog
Release Notes
From the Github release:
RSpec/EmptyExampleGroupcop when methods named like a RSpec method are used. (@Darhazer)Capybara/FeatureMethodsnot working when there is require before the spec. (@Darhazer)RSpec/EmptyLineAfterFinalLet: allow a comment to be placed after latest let, requiring empty line after the comment. (@Darhazer)RSpec/ReceiveCountscop to enforce usage of :once and :twice matchers. (@Darhazer)Commits
See the full diff on Github. The new version differs by 24 commits:
Merge pull request #622 from rubocop-hq/releaseBump version to 1.26.0Merge pull request #621 from rubocop-hq/move-repository-to-rubocop-hqChange GitHub organizationMerge pull request #618 from rubocop-rspec/fix-overwritting-setupFix OverwritingSetup raising an error for unnamed subjectMerge pull request #617 from rubocop-rspec/receive-counts-copsAdd RSpec/ReceiveCounts cop.Merge pull request #614 from rubocop-rspec/fix-aligh-brace-with-empty-fileFix investigation of empty filesMerge pull request #610 from rubocop-rspec/improve-language-usageReplace node traversal with node_searchsend_pattern already checks the receiverUse the language moduleMerge pull request #608 from rubocop-rspec/allow-comments-after-letAllow comment to be placed after latest letMerge pull request #609 from rubocop-rspec/fix-feature-methodsFix Capybara/FeatureMethods not working when there is require before the spec.Merge pull request #606 from rubocop-rspec/fix-languageSpecify the receiver in Language moduleMerge pull request #600 from rubocop-rspec/improve-contribution-guidelinesImprove contribution guidelinesMerge pull request #588 from sauloperez/doc-non-goalsAdd non-goals section documenting should vs expectDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.