From 38501f66c7ca9ff01cec5199305448a51c7a5f65 Mon Sep 17 00:00:00 2001 From: Nick Meves Date: Sun, 27 Sep 2020 15:30:45 -0700 Subject: [PATCH] Remove EmailDomain verification from GitLab provider This is handled globally --- pkg/validation/options.go | 1 - providers/gitlab.go | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/validation/options.go b/pkg/validation/options.go index 2ea35f9f5f..b54df3300c 100644 --- a/pkg/validation/options.go +++ b/pkg/validation/options.go @@ -273,7 +273,6 @@ func parseProviderInfo(o *options.Options, msgs []string) []string { case *providers.GitLabProvider: p.AllowUnverifiedEmail = o.InsecureOIDCAllowUnverifiedEmail p.Groups = o.GitLabGroup - p.EmailDomains = o.EmailDomains if o.GetOIDCVerifier() != nil { p.Verifier = o.GetOIDCVerifier() diff --git a/providers/gitlab.go b/providers/gitlab.go index eb673a3d9f..a04beca6ad 100644 --- a/providers/gitlab.go +++ b/providers/gitlab.go @@ -15,9 +15,7 @@ import ( type GitLabProvider struct { *ProviderData - Groups []string - EmailDomains []string - + Groups []string Verifier *oidc.IDTokenVerifier AllowUnverifiedEmail bool }