examples missing

[denysvitali]

As stated in the title, the directory "examples" is missing, thus the linked examples in the README.md don't work

[julestruong]

examples seem to work if you switch to v2.2.1 tag.

[richardrissanen]

The examples directory appears to have been removed in this commit. However, it did not appear to contain the linked examples that are missing within the README.md. I also do not see this 2.4.1 branch that julestruong has mentioned. If anyone would like to provide a link that would be helpful.

[sebilasse]

@richardrissanen How about the express wrapper: https://github.com/oauthjs/express-oauth-server –
but it seems the examples are not 3.x : oauthjs/express-oauth-server#10

[julestruong]

@richardrissanen i edited

[richardrissanen]

@julestruong I appreciate the edit. I believe there is a mismatch from the examples directory and what I believe @denysvitali was referencing. In the reademe.md there is a section called examples and these three bullet points are the ones that I am referring to and I believe @denysvitali is referring to.

• A simple password grant authorization example.
• A more complex password and refresh_token example.
• An advanced password, refresh_token and authorization_code (with scopes) example.

The bullet points mentioned have links that when referencing their source do not appear to be fixed by the examples directory in v2.2.1.

[denysvitali]

Exactly, I was referencing to the bullet point examples. They return a
404 because the examples/ folder is missing

On 07. 04. 16 15:33, Richard Rissanen wrote:

@julestruong https://github.com/julestruong I appreciate the edit. I
believe there is a mismatch from the examples directory and what I
believe @denysvitali https://github.com/denysvitali was referencing.
In the reademe.md there is a section called examples and these three
bullet points are the ones that I am referring to and I believe
@denysvitali https://github.com/denysvitali is referring to.

• A simple password grant authorization example <examples/password>.
• A more complex password and refresh_token example
  <examples/refresh-token>.
• An advanced password, refresh_token and authorization_code
  (with scopes) example <examples/authorization-code>.

The bullet points mentioned have links that when referencing their
source do not appear to be fixed by the examples directory in v2.2.1.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#287 (comment)

[richardrissanen]

@denysvitali Sweet! @everyone For added emphasis when comparing the bullet points source to the examples directory in v2.2.1 it does not appear to have what is needed in order for them to work.

Here is the source from the links:

https://github.com/oauthjs/node-oauth2-server/issues/examples/password
https://github.com/oauthjs/node-oauth2-server/issues/examples/refresh-token
https://github.com/oauthjs/node-oauth2-server/issues/examples/authorization-code

And v2.2.1 has an examples directory but it is filled with other directories and no reference to /password, /refresh-token, or /authorization-code to my knowledge.

[richardrissanen]

The mystery deepens. This is where the examples were added to the readme.md examples added to read.md. If you browse the tree at that time there was still no examples directory. no examples at the time. I am now uncertain if these examples have ever worked.

[manjeshpv]

using "oauth2-server": "^3.0.0-b2", support 'authorization_code', 'password', 'refresh_token', 'client_credentials'

https://github.com/manjeshpv/node-oauth2-server-implementation

To simulate, Use Postman: https://www.getpostman.com/collections/37afd82600127fbeef28

[maxtruxa]

For future reference:

Examples for the stable version currently published on npm (oauth2-server@2.4.1) are available in this commit: b36a06b445ad0a676e6175d68a8bd0b2f3353dbf.

There are currently no (official) examples for v3.