Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
OpenID connect improvements #484
This pull request removes the need of using
OpenID Connect and OAuth2 specification links:
To achieve this a new method
Example old way to send a token request:
Example fixed way to send a token request:
I successfully tested using django-oauth-toolkit the following flows:
Adding support to OpenID Connect is a working in progress based on this pull request.
Turns out this leads to problems with existing code that doesn't have
To fix we could catch the
referenced this pull request
Oct 19, 2017
Can we please back this out? It's doing more harm than good right now.
I love the idea of OpenIDConnect support, but I also think it should be optional and not shoved into the library without consideration of servers/providers/clients that don't want it or don't need it.
My opinion is to let the OAuth2 library do Oauth2, add the extras openid connect wants on top with a library of its own that uses the openid2 library, and keep a good separation of concerns so the code stays as SOLID and DRY as possible.
@duaneking Not so easy to back out OIDC entirely, since its support was added long before this PR already, and mostly modular/separate from the existing code.
The exception being the preconfigured server code, which I agree would have been better to leave alone and add a dedicated OIDC server. But undoing this now would also be a breaking change.
IMO this PR should not have been a breaking change at all, and my suggestion would be: Find a fix to make this non-breaking and release 2.0.6, and plan for more structural changes in 3.0.