Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better user mapping #113

Merged
merged 14 commits into from May 13, 2013
Merged

Better user mapping #113

merged 14 commits into from May 13, 2013

Conversation

@obfuscurity
Copy link
Owner

@obfuscurity obfuscurity commented May 13, 2013

GitHub users that choose not to publicize their membership in an organization will not have their email available to us. Therefore we need to choose something else to map from their OAuth identity to our internal User model. This PR adds a uid column to the User model which will store either the id number from a Google OAuth identity_url or the uid value from GitHub OAuth.

After performing the upgrade you'll need to migrate (bundle exec rake db:migrate:up) and then restart the service again to load the new User model. In the off chance that you're already running the new User model code (#87), you will probably want to delete your users (delete from users; or VERSION=6 bundle exec rake db:migrate:to && bundle exec rake db:migrate:up) before performing the aforementioned migration.

obfuscurity added a commit that referenced this pull request May 13, 2013
Better user mapping
@obfuscurity obfuscurity merged commit be2e5f7 into master May 13, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@obfuscurity obfuscurity deleted the replace_email_with_uid branch May 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.