Fix apache and support Debian 7.x #1

Closed
wants to merge 6 commits into
from

Projects

None yet

3 participants

@aw
aw commented Oct 22, 2013

These commits fix an Apache misconfiguration and remove a module in order for this to run on Debian 7.

@obfuscurity
Owner

Apache on Ubuntu 13.10 won't load the graphite site configuration unless it ends in .conf. I'm not sure if this is an Ubuntu 13.10-ism or Apache2.4-ism.

From the install run:

ERROR: Site graphite does not exist!

Fixing the site:

root@graphite:~/synthesize# mv /etc/apache2/sites-available/graphite /etc/apache2/sites-available/graphite.conf
root@graphite:~/synthesize# a2ensite graphite
Enabling site graphite.
To activate the new configuration, you need to run:
  service apache2 reload
@obfuscurity
Owner

And the Require all granted directive is required for Apache2.4 access to work. Otherwise you get a permission denied.

@aw
aw commented Oct 22, 2013

Debian 7 ships with Apache 2.2. I'll try to figure out if it's an apache or ubuntu issue, and push a fix shortly. Thanks.

@obfuscurity
Owner

Ok, these are both changes in Apache 2.4 that are incompatible (afaik) with Apache 2.2. Note, compatibility with Debian 7 is not worth (imho) introducing conditionals. The goal of the project is quick installation [on at least one specific platform], not to support all possible platforms.

@aw
aw commented Oct 22, 2013

I disagree. a2ensite is a 'debian' thing, not an Apache thing.

Also Ubuntu 13.10 is not LTS, and your scripts are wonderful so I don't see why you would limit usage to people who only want it for testing / non-production purposes..

@aw
aw commented Oct 22, 2013

Hmmm i'm not sure if this works in Apache 2.4 that ships with Ubuntu 13..

Order allow,deny
Allow from all
@obfuscurity
Owner

I disagree. a2ensite is a 'debian' thing, not an Apache thing.

I stand corrected. ๐Ÿ‘๐Ÿ˜

Also Ubuntu 13.10 is not LTS, and your scripts are wonderful so I don't see why you would limit usage to people who only want it for testing / non-production purposes..

Because it will become a bloated mess of conditionals as other enterprising folks begin submitting PRs to add support for other distributions. I โค๏ธ your Ansible fork and hope folks use that if they want to install a basic Graphite on distribution != Ubuntu 13.10. CMs are great for abstracting out those icky OS-specific bits, but that's not the focus of this project.

@aw
aw commented Oct 22, 2013

I understand. Sorry to step on your toes ๐Ÿ˜ฌ

@obfuscurity
Owner

You're not stepping on my toes at all. I appreciate the feedback and I wish there was a clean way to support both.

@Finkregh

๐Ÿ‘ for this conversation + the patches ๐Ÿ˜€

@aw aw closed this Oct 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment