using jsonp to allow for crossdomain xhr requests #27

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@captnswing

Graphite seems to support jsonp as of late. I changed tasseo.js to use jsonp in the jQuery.ajax xhr call.

This allows tasseo to be used on another machine than the graphite machine.

@obfuscurity

This comment has been minimized.

Show comment Hide comment
@obfuscurity

obfuscurity Jun 20, 2012

Owner

@captnswing - Tasseo used to do JSONP. Unfortunately, there is a significant memory leak condition when using JSONP.

#17
262df59

I'm surprised this diff works as submitted. IIRC you need to also set jsonp: 'jsonp' so it will recognize Graphite's callback name.

Owner

obfuscurity commented Jun 20, 2012

@captnswing - Tasseo used to do JSONP. Unfortunately, there is a significant memory leak condition when using JSONP.

#17
262df59

I'm surprised this diff works as submitted. IIRC you need to also set jsonp: 'jsonp' so it will recognize Graphite's callback name.

@captnswing

This comment has been minimized.

Show comment Hide comment
@captnswing

captnswing Jun 21, 2012

ok, apologies for not scanning earlier PRs before submitting this.
PS works on my machine, so far so good :-P

ok, apologies for not scanning earlier PRs before submitting this.
PS works on my machine, so far so good :-P

@captnswing captnswing closed this Jun 21, 2012

@obfuscurity

This comment has been minimized.

Show comment Hide comment
@obfuscurity

obfuscurity Jun 21, 2012

Owner

@captnswing - No worries. FWIW I'd like to offer JSONP support again, but it will need to be raw javascript without jQuery (as it appears they have no intention on fixing this bug).

Owner

obfuscurity commented Jun 21, 2012

@captnswing - No worries. FWIW I'd like to offer JSONP support again, but it will need to be raw javascript without jQuery (as it appears they have no intention on fixing this bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment