Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unregister with nil handle #1064

Merged

Conversation

Projects
None yet
2 participants
@simpsont-oci
Copy link
Member

commented Feb 19, 2019

Updating DataWriterImpl's unregister_instance to behave like dispose, where it only does the instance handle lookup when the input handle is NIL. Before, it would pass the wrong handle into the write data container after doing a lookup when the input handle was NIL. I also added a test case to cover the broken behavior, in case we need to revert to more complicated handle checking inside unregister_instance.

@mitza-oci mitza-oci merged commit 5a2866b into objectcomputing:master Feb 19, 2019

23 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
OpenDDS_Pull_Requests Build #562 (merge) stopped
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
objectcomputing.OpenDDS Build #20190219.3 succeeded
Details
objectcomputing.OpenDDS (Linux CLANG5) Linux CLANG5 succeeded
Details
objectcomputing.OpenDDS (Linux CLANG6) Linux CLANG6 succeeded
Details
objectcomputing.OpenDDS (Linux CLANG7) Linux CLANG7 succeeded
Details
objectcomputing.OpenDDS (Linux Debug) Linux Debug succeeded
Details
objectcomputing.OpenDDS (Linux GCC6) Linux GCC6 succeeded
Details
objectcomputing.OpenDDS (Linux GCC7) Linux GCC7 succeeded
Details
objectcomputing.OpenDDS (Linux Release) Linux Release succeeded
Details
objectcomputing.OpenDDS (Linux Safety) Linux Safety succeeded
Details
objectcomputing.OpenDDS (Linux SafetyBaseNoBuiltinTopics) Linux SafetyBaseNoBuiltinTopics succeeded
Details
objectcomputing.OpenDDS (Linux Security) Linux Security succeeded
Details
objectcomputing.OpenDDS (Linux SecurityWithoutFeatures) Linux SecurityWithoutFeatures succeeded
Details
objectcomputing.OpenDDS (Linux WChar) Linux WChar succeeded
Details
objectcomputing.OpenDDS (VisualStudio2017 Debug32) VisualStudio2017 Debug32 succeeded
Details
objectcomputing.OpenDDS (VisualStudio2017 Debug64) VisualStudio2017 Debug64 succeeded
Details
objectcomputing.OpenDDS (VisualStudio2017 Release32) VisualStudio2017 Release32 succeeded
Details
objectcomputing.OpenDDS (VisualStudio2017 Release64) VisualStudio2017 Release64 succeeded
Details
objectcomputing.OpenDDS (macOS Debug) macOS Debug succeeded
Details
objectcomputing.OpenDDS (macOS Release) macOS Release succeeded
Details

mitza-oci added a commit that referenced this pull request Apr 1, 2019

Merge pull request #1064 from simpsont-oci/fix_unregister_with_nil_ha…
…ndle

Fix unregister with nil handle

(cherry picked from commit 5a2866b)

# Conflicts:
#	bin/dcps_tests.lst
#	tests/DCPS/FooTest3_0/run_test.pl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.