Chore 2131/change primitive entity columns to use wrappers #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to use Float wrapper classes
…into chore-2131/change-primitive-entity-columns-to-use-wrappers
S78901
previously approved these changes
Mar 27, 2024
mkimberlin
reviewed
Mar 27, 2024
mkimberlin
reviewed
Mar 27, 2024
server/src/main/java/com/objectcomputing/checkins/services/employee_hours/EmployeeHours.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@borinquenkid and I have walked through the front-end of the app and did not find any issues due to the Jackson serialization change. We covered the majority of pages, but if anyone thinks of any obscure pages/flows that we may have overlooked, please let us know. |
Member
|
So, this looks good to me, except there seem to be some other inconsistencies with the @NotNull annotations between constructors. Otherwise, I'm ready to bring this in. |
mkimberlin
approved these changes
Apr 3, 2024
weiqigao
approved these changes
Apr 3, 2024
pieperm
deleted the
chore-2131/change-primitive-entity-columns-to-use-wrappers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2131
Closes #2132