From 5833a9107a52a61facff30d5cedf26bca2778859 Mon Sep 17 00:00:00 2001 From: Luciano Belotto Date: Wed, 16 Oct 2024 09:42:02 -0400 Subject: [PATCH] 2024-10-16 - Assign null reviewer if reviewee has no supervisor --- web-ui/src/components/reviews/TeamReviews.jsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/web-ui/src/components/reviews/TeamReviews.jsx b/web-ui/src/components/reviews/TeamReviews.jsx index b8cf9058da..b06a764d4d 100644 --- a/web-ui/src/components/reviews/TeamReviews.jsx +++ b/web-ui/src/components/reviews/TeamReviews.jsx @@ -257,7 +257,8 @@ const TeamReviews = ({ onBack, periodId }) => { // Now that teamMembers has been updated, we need to make sure that the // assignments reflects the set of team members. const ids = teamMembers.map(m => m.id); - setAssignments(assignments.filter(a => a.revieweeId && ids.includes(a.revieweeId))); + const newAssignments = assignments.filter(a => a.revieweeId && ids.includes(a.revieweeId)); + setAssignments(newAssignments); }; const addAssignmentForMemberWithNone = async (members) => { @@ -268,6 +269,9 @@ const TeamReviews = ({ onBack, periodId }) => { if (!!!exists && member.supervisorid) { const reviewers = [{ id: member.supervisorid }]; updateReviewers(member, reviewers); + } else if (!!!exists && !!!member.supervisorid) { + const reviewers = [{ id: null }]; + updateReviewers(member, reviewers); } }); }