Skip to content

fix(#3257): optimize some xsls#3457

Merged
yegor256 merged 2 commits intoobjectionary:masterfrom
maxonfjvipon:fix/#3257/optimize-some-xsls
Nov 2, 2024
Merged

fix(#3257): optimize some xsls#3457
yegor256 merged 2 commits intoobjectionary:masterfrom
maxonfjvipon:fix/#3257/optimize-some-xsls

Conversation

@maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Nov 2, 2024

Ref: #3257


PR-Codex overview

This PR focuses on refining XSL templates in various files to enhance the matching criteria and processing logic for XML elements, particularly those related to the o element with attributes such as @star, @base, and @data.

Detailed summary

  • Changed match patterns for o elements in stars-to-tuples.xsl and unit-test-without-phi.xsl.
  • Updated @Param annotation in XslBenchmarkIT.java to include additional XSL files.
  • Modified variable selection logic in external-weak-typed-atoms.xsl.
  • Enhanced template matching for o elements in resolve-aliases.xsl and add-refs.xsl.
  • Improved data handling in explicit-data.xsl with new modes for templates.
  • Streamlined matching logic for o elements with specific attributes across several files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit 5384cd8 into objectionary:master Nov 2, 2024
@0crat
Copy link

0crat commented Nov 4, 2024

@maxonfjvipon Great work on your contribution! 🌟 You've earned +4 points, which includes adjustments for code review and comments. Your running balance is now +24. Keep up the momentum and remember to focus on both speed and quality in your future submissions. We look forward to seeing more from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants