fix(dev): print seeded dev-admin credentials in the serve startup banner#1510
Merged
Conversation
The in-process dev seed confirmed via ctx.logger during runtime.start(),
inside serve's boot-quiet window, so the line was swallowed and never
reached the console (a regression vs the old HTTP seed, which printed the
credentials). plugin-auth now records the seed result on the `auth`
service; serve reads it after restoreOutput() and renders it in the ready
banner:
🔑 Dev admin: admin@objectos.ai / admin123
seeded on empty DB · dev only — do not use in production
Shown only when an admin was actually seeded this boot (empty DB), so
stale credentials are never displayed on a populated DB. Visible in both
`serve --dev` and `os dev` (the child's stdout is inherited by the parent
terminal). Verified: line appears on a fresh DB, absent on a second run.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #1503 moved dev-admin seeding in-process, the confirmation line went silent. The seed runs inside
runtime.start(), which is withinserve's boot-quiet window (stdout is suppressed to produce a clean banner, restored only afterward). So thectx.logger.info('🔑 Dev admin seeded …')line was swallowed — a DX regression vs the old HTTP seed, which printed the credentials.Fix
plugin-authrecords the seed result on theauthservice (AuthManager.devSeedResult).servereads it afterrestoreOutput()and renders it inside the ready banner:os devspawnsservewith inherited stdout, printing from the serve child covers bothserve --devstandalone and theos devconsole — no IPC needed for this.devSeedResultstays undefined, and nothing prints.NODE_ENV=development).Verification (showcase)
🔑 Dev admin: …✓Tests: cli 144, plugin-auth 88 — all green. Typecheck/build clean.
🤖 Generated with Claude Code