New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the definition of HP:0100603 Toxemia of pregnancy: replaced "Ecplamsia" with "Eclampsia". #501

Merged
merged 1 commit into from Sep 13, 2015

Conversation

Projects
None yet
3 participants
@sdumitriu
Contributor

sdumitriu commented Sep 12, 2015

No description provided.

@cmungall

This comment has been minimized.

Show comment
Hide comment
@cmungall

cmungall Sep 13, 2015

Member

Thanks!

Is this our first PR on HPO? Cool! Note that if people are switching
version of Protege arbitrarily we will get some spurious diffs which
could cause this PR to conflict (in which case it should be easy to
manually redo Sergiu's changes).

Are you OK to do this @drseb?

On 12 Sep 2015, at 13:25, Sergiu Dumitriu wrote:

You can view, comment on, or merge this pull request online at:

#501

-- Commit Summary --

  • Typo in the definition of HP:0100603 Toxemia of pregnancy: replaced
    "Ecplamsia" with "Eclampsia".

-- File Changes --

M src/ontology/hp-edit.owl (4)

-- Patch Links --

https://github.com/obophenotype/human-phenotype-ontology/pull/501.patch
https://github.com/obophenotype/human-phenotype-ontology/pull/501.diff


Reply to this email directly or view it on GitHub:
#501

Member

cmungall commented Sep 13, 2015

Thanks!

Is this our first PR on HPO? Cool! Note that if people are switching
version of Protege arbitrarily we will get some spurious diffs which
could cause this PR to conflict (in which case it should be easy to
manually redo Sergiu's changes).

Are you OK to do this @drseb?

On 12 Sep 2015, at 13:25, Sergiu Dumitriu wrote:

You can view, comment on, or merge this pull request online at:

#501

-- Commit Summary --

  • Typo in the definition of HP:0100603 Toxemia of pregnancy: replaced
    "Ecplamsia" with "Eclampsia".

-- File Changes --

M src/ontology/hp-edit.owl (4)

-- Patch Links --

https://github.com/obophenotype/human-phenotype-ontology/pull/501.patch
https://github.com/obophenotype/human-phenotype-ontology/pull/501.diff


Reply to this email directly or view it on GitHub:
#501

@drseb

This comment has been minimized.

Show comment
Hide comment
@drseb

drseb Sep 13, 2015

Member

Yes it is our first PR. The fact that the OWL file looks very different on different machines makes me think that PRs are no good idea for hp-edit.owl. @cmungall Let's discuss this soon.

Member

drseb commented Sep 13, 2015

Yes it is our first PR. The fact that the OWL file looks very different on different machines makes me think that PRs are no good idea for hp-edit.owl. @cmungall Let's discuss this soon.

drseb added a commit that referenced this pull request Sep 13, 2015

Merge pull request #501 from sdumitriu/master
Typo in the definition and semi-formal definition of HP:0100603 Toxemia of pregnancy: replaced "Ecplamsia" with "Eclampsia".

@drseb drseb merged commit 7b8e9f8 into obophenotype:master Sep 13, 2015

@drseb

This comment has been minimized.

Show comment
Hide comment
@drseb

drseb Sep 13, 2015

Member

Thanks @sdumitriu

Member

drseb commented Sep 13, 2015

Thanks @sdumitriu

@cmungall

This comment has been minimized.

Show comment
Hide comment
@cmungall

cmungall Sep 13, 2015

Member

@drseb - if we get a new Protege release and everyone standardizes on using either this version or a subsequent version the problem will be solved. See owlcs/owlapi#273 (comment)

Member

cmungall commented Sep 13, 2015

@drseb - if we get a new Protege release and everyone standardizes on using either this version or a subsequent version the problem will be solved. See owlcs/owlapi#273 (comment)

@drseb drseb added the typo label Oct 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment