Completed support for Python 3 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To sort manifest entries (which are entries of OrderedDict), an explicit ordering must be defined in Python 3. See https://docs.python.org/3/whatsnew/3.0.html#ordering-comparisons
This makes classdiff, distdiff and jardiff tests pass under Python 3.
This makes all test pass in Python 3.
- Travis CI tests for Python 3 added - Trove classifier in setup.py updated - README.md indicates support for Python 2.7, 3,5 and 3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes Py3 support. While the merged #94 handled "incoming" text/binary data conversions, this one handles "outgoing".
Differently from what I proposed previously in #89 , this PR does not reduce function interfaces not to handle streams. This results in much smaller changes to the existing code.
Closes #53.