Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centroid (and geoCentroid) sometimes fail when using tips #2085

Closed
Fil opened this issue Jun 14, 2024 · 1 comment · Fixed by #2088
Closed

centroid (and geoCentroid) sometimes fail when using tips #2085

Fil opened this issue Jun 14, 2024 · 1 comment · Fixed by #2088
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Jun 14, 2024

see https://talk.observablehq.com/t/faceting-a-choropleth/9387

@Fil Fil added the bug Something isn’t working label Jun 14, 2024
Fil added a commit that referenced this issue Jun 14, 2024
@mbostock
Copy link
Member

mbostock commented Jun 14, 2024

My take is that the geo mark doesn’t support the tip option because the geo mark doesn’t have x and y channels. So this is either “working as intended” or a duplicate of #2087 — if we want the geo mark to support the tip option, it should support the tip option (and you shouldn’t have to combine it with the centroid/geoCentroid transform).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
2 participants